Skip to content

Commit c898bfe

Browse files
committed
refactor(Docker): move environment variables to Docker Compose .env
1 parent 13a1016 commit c898bfe

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

Diff for: .env.docker-compose

+7
Original file line numberDiff line numberDiff line change
@@ -7,3 +7,10 @@ DB_USER=activity
77
DB_PASSWORD=activity
88
DB_HOST=db
99
DB_PORT=5432
10+
11+
ACTIVITY_CE_DB_ENGINE=django.db.backends.postgresql
12+
ACTIVITY_CE_DB_NAME=activity_dev
13+
ACTIVITY_CE_DB_USER=activity
14+
ACTIVITY_CE_DB_PASSWORD=activity
15+
ACTIVITY_CE_DB_HOST=db
16+
ACTIVITY_CE_DB_PORT=5432

Diff for: .github/workflows/activity_ci_cd.yml

-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ jobs:
4545
coverage report
4646
echo "----------- Upload test coverage ---------"
4747
bash <(curl -s https://codecov.io/bash)
48-
echo ${{github.ref}}
4948
5049
Infrastructure:
5150
runs-on: ubuntu-latest

Diff for: Dockerfile

-7
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,6 @@ RUN apk update && apk add postgresql-dev gcc python3-dev musl-dev
1313
ENV PYTHONDONTWRITEBYTECODE 1 #Prevents Python from writing pyc files to disc
1414
ENV PYTHONUNBUFFERED 1 #Prevents Python from buffering stdout and stderr
1515

16-
# Set environment variables
17-
ENV ACTIVITY_CE_DB_ENGINE=django.db.backends.postgresql
18-
ENV ACTIVITY_CE_DB_NAME=activity_dev
19-
ENV ACTIVITY_CE_DB_USER=activity
20-
ENV ACTIVITY_CE_DB_PASSWORD=activity
21-
ENV ACTIVITY_CE_DB_HOST=db
22-
ENV ACTIVITY_CE_DB_PORT=5432
2316

2417
# Install dependencies
2518
RUN pip install --upgrade pip

0 commit comments

Comments
 (0)