Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support existingSecrets and httproute #9

Open
rdmcguire opened this issue Mar 27, 2025 · 2 comments · May be fixed by #14
Open

Support existingSecrets and httproute #9

rdmcguire opened this issue Mar 27, 2025 · 2 comments · May be fixed by #14

Comments

@rdmcguire
Copy link

The configuration contains many sensitive values, such as database password, client secrets, and smtp auth; but only supports configMap. The entire community.config key should support existingSecret as an option, to support the good advice given in general-guidelines.md: - Use secret management solutions for sensitive data.

Additionally, the Gateway API has superseded the Ingress API, support for defining an httproute would be a nice to have.

I'd be willing to submit a PR with support for config from a secret, and also one for httproute support. Please do let me know if there is appetite in this project for external contribution.

@AlePini
Copy link

AlePini commented Mar 28, 2025

Totally agree about using secrets for sensitive data, but I think is easier to maintain separated secrets for each section, rather than having a huge one containing every env var.

I was working on this specific issue in the last few days and I just created a PR, check if it resolve your issue!

@JakobStadlhuber
Copy link

please merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants