Skip to content

Commit fcce488

Browse files
committed
Require two LGTMs for non-maintainer changes.
Docker-DCO-1.1-Signed-off-by: Victor Marmol <[email protected]> (github: vmarmol)
1 parent da2edd6 commit fcce488

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

CONTRIBUTORS_GUIDE.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -112,12 +112,12 @@ and that all the tests pass.
112112
libcontainer maintainers use LGTM (looks good to me) in comments on the code review
113113
to indicate acceptance.
114114

115-
A change requires LGTMs from at lease one maintainer of each
116-
component affected. For example, if a change affects `netlink/` and `security/`, it
117-
needs at least one LGTM from the maintainers of `netlink/` AND, separately, at
118-
least one LGTM from the maintainers of `security/`.
115+
A change requires LGTMs from at lease two maintainers. One of those must come from
116+
a maintainer of the component affected. For example, if a change affects `netlink/`
117+
and `security`, it needs at least one LGTM from a maintainer of each. Maintainers
118+
only need one LGTM as presumably they LGTM their own change.
119119

120-
For more details see [MAINTAINERS.md](hack/MAINTAINERS.md)
120+
For more details see [MAINTAINERS.md](MAINTAINERS.md)
121121

122122
### Sign your work
123123

MAINTAINERS_GUIDE.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ All decisions are pull requests, and the relevant maintainers make
6363
decisions by accepting or refusing the pull request. Review and acceptance
6464
by anyone is denoted by adding a comment in the pull request: `LGTM`.
6565
However, only currently listed `MAINTAINERS` are counted towards the required
66-
majority.
66+
two LGTMs.
6767

6868
libcontainer follows the timeless, highly efficient and totally unfair system
6969
known as [Benevolent dictator for life](http://en.wikipedia.org/wiki/Benevolent_Dictator_for_Life), with Michael Crosby in the role of BDFL.

0 commit comments

Comments
 (0)