Skip to content

Commit 1b8e6ec

Browse files
Merge pull request opencontainers#1452 from justincormack/make-flags
Allow specification of general Go build flags and ldflags
2 parents 67bd2ab + 7e3934a commit 1b8e6ec

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

Makefile

+5-5
Original file line numberDiff line numberDiff line change
@@ -27,18 +27,18 @@ SHELL := $(shell command -v bash 2>/dev/null)
2727
.DEFAULT: runc
2828

2929
runc: $(SOURCES)
30-
go build -i -ldflags "-X main.gitCommit=${COMMIT} -X main.version=${VERSION}" -tags "$(BUILDTAGS)" -o runc .
30+
go build -i $(EXTRA_FLAGS) -ldflags "-X main.gitCommit=${COMMIT} -X main.version=${VERSION} $(EXTRA_LDFLAGS)" -tags "$(BUILDTAGS)" -o runc .
3131

3232
all: runc recvtty
3333

3434
recvtty: contrib/cmd/recvtty/recvtty
3535

3636
contrib/cmd/recvtty/recvtty: $(SOURCES)
37-
go build -i -ldflags "-X main.gitCommit=${COMMIT} -X main.version=${VERSION}" -tags "$(BUILDTAGS)" -o contrib/cmd/recvtty/recvtty ./contrib/cmd/recvtty
37+
go build -i $(EXTRA_FLAGS) -ldflags "-X main.gitCommit=${COMMIT} -X main.version=${VERSION} $(EXTRA_LDFLAGS)" -tags "$(BUILDTAGS)" -o contrib/cmd/recvtty/recvtty ./contrib/cmd/recvtty
3838

3939
static: $(SOURCES)
40-
CGO_ENABLED=1 go build -i -tags "$(BUILDTAGS) cgo static_build" -ldflags "-w -extldflags -static -X main.gitCommit=${COMMIT} -X main.version=${VERSION}" -o runc .
41-
CGO_ENABLED=1 go build -i -tags "$(BUILDTAGS) cgo static_build" -ldflags "-w -extldflags -static -X main.gitCommit=${COMMIT} -X main.version=${VERSION}" -o contrib/cmd/recvtty/recvtty ./contrib/cmd/recvtty
40+
CGO_ENABLED=1 go build -i $(EXTRA_FLAGS) -tags "$(BUILDTAGS) cgo static_build" -ldflags "-w -extldflags -static -X main.gitCommit=${COMMIT} -X main.version=${VERSION} $(EXTRA_LDFLAGS)" -o runc .
41+
CGO_ENABLED=1 go build -i $(EXTRA_FLAGS) -tags "$(BUILDTAGS) cgo static_build" -ldflags "-w -extldflags -static -X main.gitCommit=${COMMIT} -X main.version=${VERSION} $(EXTRA_LDFLAGS)" -o contrib/cmd/recvtty/recvtty ./contrib/cmd/recvtty
4242

4343
release:
4444
@flag_list=(seccomp selinux apparmor static); \
@@ -62,7 +62,7 @@ release:
6262
CGO_ENABLED=1; \
6363
}; \
6464
echo "Building target: $$output"; \
65-
go build -i -ldflags "$$ldflags" -tags "$$tags" -o "$$output" .; \
65+
go build -i $(EXTRA_FLAGS) -ldflags "$$ldflags $(EXTRA_LDFLAGS)" -tags "$$tags" -o "$$output" .; \
6666
done
6767

6868
dbuild: runcimage

0 commit comments

Comments
 (0)