Skip to content

Commit 25a9379

Browse files
authored
fix: bump minimum Node.js to 18 (#1521)
* fix: bump minimum Node.js to 18 * ci: use .nvmrc for default Node.js version * fix: bump website minimum Node.js to 18 * ci: swap back to version number
1 parent b58c7fe commit 25a9379

File tree

7 files changed

+18
-16
lines changed

7 files changed

+18
-16
lines changed

.github/workflows/development.yml

+6-5
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,10 @@ jobs:
3535
fail-fast: false
3636
matrix:
3737
node:
38-
- 14
39-
- 16
4038
- 18
39+
- 20
40+
- 22
41+
- 23
4142
os: [ubuntu-latest, macos-latest, windows-latest]
4243

4344
steps:
@@ -65,23 +66,23 @@ jobs:
6566
run: git diff --exit-code
6667

6768
- name: Run tests
68-
if: matrix.node != '16' || matrix.os != 'ubuntu-latest'
69+
if: matrix.node != '18' || matrix.os != 'ubuntu-latest'
6970
uses: nick-invision/retry@v2
7071
with:
7172
timeout_minutes: 20
7273
max_attempts: 3
7374
command: npm run test
7475

7576
- name: Run coverage
76-
if: matrix.node == '16' && matrix.os == 'ubuntu-latest'
77+
if: matrix.node == '18' && matrix.os == 'ubuntu-latest'
7778
uses: nick-invision/retry@v2
7879
with:
7980
timeout_minutes: 20
8081
max_attempts: 3
8182
command: npm run test:coverage
8283

8384
- name: ⬆️ Upload coverage to Codecov
84-
if: matrix.node == '16' && matrix.os == 'ubuntu-latest'
85+
if: matrix.node == '18' && matrix.os == 'ubuntu-latest'
8586
uses: codecov/codecov-action@v3
8687
with:
8788
files: ./coverage/coverage-final.json

.github/workflows/production.yml

+6-5
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,10 @@ jobs:
3535
fail-fast: false
3636
matrix:
3737
node:
38-
- 14
39-
- 16
4038
- 18
39+
- 20
40+
- 22
41+
- 23
4142
os: [ubuntu-latest, macos-latest, windows-latest]
4243

4344
steps:
@@ -65,23 +66,23 @@ jobs:
6566
run: git diff --exit-code
6667

6768
- name: Run tests
68-
if: matrix.node != '16' || matrix.os != 'ubuntu-latest'
69+
if: matrix.node != '18' || matrix.os != 'ubuntu-latest'
6970
uses: nick-invision/retry@v2
7071
with:
7172
timeout_minutes: 20
7273
max_attempts: 3
7374
command: npm run test
7475

7576
- name: Run coverage
76-
if: matrix.node == '16' && matrix.os == 'ubuntu-latest'
77+
if: matrix.node == '18' && matrix.os == 'ubuntu-latest'
7778
uses: nick-invision/retry@v2
7879
with:
7980
timeout_minutes: 20
8081
max_attempts: 3
8182
command: npm run test:coverage
8283

8384
- name: ⬆️ Upload coverage to Codecov
84-
if: matrix.node == '16' && matrix.os == 'ubuntu-latest'
85+
if: matrix.node == '18' && matrix.os == 'ubuntu-latest'
8586
uses: codecov/codecov-action@v3
8687
with:
8788
files: ./coverage/coverage-final.json

.nvmrc

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v16
1+
v18

package-lock.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"url": "git+https://github.com/htmlhint/HTMLHint.git"
1818
},
1919
"engines": {
20-
"node": ">=14"
20+
"node": ">=18"
2121
},
2222
"license": "MIT",
2323
"main": "dist/htmlhint.js",

website/package-lock.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

website/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,9 @@
4646
"url": "https://opencollective.com/htmlhint"
4747
},
4848
"engines": {
49-
"node": ">=16"
49+
"node": ">=18"
5050
},
5151
"volta": {
52-
"node": "16.20.2"
52+
"node": "18.20.8"
5353
}
5454
}

0 commit comments

Comments
 (0)