Skip to content

Dependabot can't resolve your Rust dependency files #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dependabot-preview bot opened this issue May 15, 2019 · 3 comments
Closed

Dependabot can't resolve your Rust dependency files #225

dependabot-preview bot opened this issue May 15, 2019 · 3 comments

Comments

@dependabot-preview
Copy link
Contributor

Dependabot can't resolve your Rust dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

error: failed to parse manifest at `/home/dependabot/dependabot-updater/dependabot_tmp_dir/examples/Cargo.toml`

Caused by:
  the binary target name `examples` is forbidden

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

You can mention @dependabot in the comments below to contact the Dependabot team.

@yoshuawuyts
Copy link
Member

yoshuawuyts commented May 16, 2019

@prasannavl it looks like our dependency bot is having trouble with the new structure. Would it perhaps be an idea to have a regular examples dir without it being a separate workspace member?

It'd be nice if we could resolve this so staying on top of our dependencies stays automated.

@prasannavl
Copy link
Contributor

prasannavl commented May 16, 2019

the binary target name 'examples' is forbidden - Yikes!

@dependabot Is there a reason examples is forbidden as the crate name? (It's allowed by cargo as a lib, but only not as a binary).

@yoshuawuyts - Our options in the interim:

  • Rename examples to either example or tide-examples and call it a day.
  • Including middleware crates as dev-deps to tide makes me cringe, but should work to go back, though this would mean, one of these:
    • Switch to either runtime/gloo like folder structure, or examples will be hidden under tide directory
    • Keep current structure for main project but symlink examples to root (GitHub supports this, but not sure if that'll work on Windows).
    • Does cargo manifest provide a specific option to have different examples dir? Then, this might be a solution.

Related: #227

@Nemo157
Copy link
Contributor

Nemo157 commented May 17, 2019

examples is not allowed as the name of a binary, but it is allowed as the name of a library. Because there is no src/main.rs in the crate cargo doesn't treat it as a binary currently. It appears that dependabot tries using the manifest with both src/lib.rs and src/main.rs present which can't work for this crate.

Another way to workaround this would be adding package.autobins = false to the manifest, but that's not really an option with #227.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants