Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shape Error in Llama4VisionMLP2 #37321

Open
4 tasks
priyammaz opened this issue Apr 6, 2025 · 2 comments
Open
4 tasks

Shape Error in Llama4VisionMLP2 #37321

priyammaz opened this issue Apr 6, 2025 · 2 comments
Labels

Comments

@priyammaz
Copy link

System Info

self.fc2 = nn.Linear(config.projector_output_dim, config.projector_output_dim, bias=False)

Im pretty sure this should be:

self.fc2 = nn.Linear(config.projector_input_dim, config.projector_output_dim, bias=False)

Who can help?

No response

Information

  • The official example scripts
  • My own modified scripts

Tasks

  • An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
  • My own task or dataset (give details below)

Reproduction

Nothing to reproduce, I just noticed a shape mistake, but i havent had a chance to run it personally yet!

Expected behavior

The output of fc1 should be the input of fc2, unless there is some hidden logic that I am missing

@priyammaz priyammaz added the bug label Apr 6, 2025
@priyammaz
Copy link
Author

I now see the input and output are the same in the config, but still this can be a bug if someone changed that!

@Rocketknight1
Copy link
Member

cc @ArthurZucker but this looks like a bug, yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants