Skip to content

Improve the way vCPU stop reason is implemented to reduce code duplication #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dblnz opened this issue Mar 27, 2025 · 0 comments · May be fixed by #456
Open

Improve the way vCPU stop reason is implemented to reduce code duplication #380

dblnz opened this issue Mar 27, 2025 · 0 comments · May be fixed by #456
Assignees
@dblnz
Labels
lifecycle/confirmed Bug is verified or proposal seems reasonable
Milestone
v0.5.0

Comments

@dblnz
Copy link
Contributor

dblnz commented Mar 27, 2025 •
edited
Loading

This is a follow up issue for the #327 PR.

  1. Check the comments for more context.
    The way get_stop_reason method is implemented introduces code duplication between kvm and mshv, this can be improved.

  2. it is worth investigating whether mshv has a way of checking which exception was intercepted.
    Link 1 and Link 2 are relevant to this.

  3. Check whether gdb does not complain when an unknown vCPU exit reason is reported as SwBp
@dblnz dblnz added kind/refactor For PRs that restructure or remove code without adding new functionality. lifecycle/confirmed Bug is verified or proposal seems reasonable labels Mar 27, 2025
@dblnz dblnz self-assigned this Mar 27, 2025
@dblnz dblnz mentioned this issue Mar 27, 2025
Merged
@danbugs danbugs removed the kind/refactor For PRs that restructure or remove code without adding new functionality. label Apr 23, 2025
@danbugs danbugs modified the milestones: v0.4.0, v0.5.0 Apr 23, 2025
@dblnz dblnz linked a pull request May 2, 2025 that will close this issue
Open
@dblnz dblnz moved this to In Progress in Hyperlight Milestones May 2, 2025
@dblnz dblnz closed this as completed by moving to In Progress in Hyperlight Milestones May 2, 2025
@dblnz dblnz reopened this May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dblnz dblnz

Labels
lifecycle/confirmed Bug is verified or proposal seems reasonable
Projects
Hyperlight Milestones
Status: In Progress
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

Gdb debug improvements dblnz/hyperlight
2 participants
@dblnz @danbugs