Instrumenting vite build causes thrown error

[petertellgren]

Describe the bug

While building a instrumented version of the vite app with the plugin, the resulting JS code contains a uncaught TypeError if the typescript source code contains an enum.

Reproduction

https://stackblitz.com/edit/vitejs-vite-vxbpagry

Steps to reproduce

Run npm install followed by npm run build and npm run preview

open console and see the error:

Uncaught TypeError: Cannot set properties of undefined (setting 'foo')
    at index-<ID>.js:40:59252

The app does not run due to the error thrown

The app runs fine in dev mode using npm run dev

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  npmPackages:
    @vitejs/plugin-react: ^4.3.4 => 4.3.4 
    vite: ^6.0.5 => 6.0.6 
    vite-plugin-istanbul: 6.0.2 => 6.0.2

Used Package Manager

npm

Logs

No response

Validations

• Read the Contributing Guidelines.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a vite-plugin-istanbul issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• The provided reproduction is a minimal reproducible example of the bug.

[iFaxity]

Hello @petertellgren, as this seems like it is an issue in babel or in instanbul-lib-instrument as it is the code transforming and adding the necessary instrumentation. This package merely interfaces it to Vite.

I unfortunately cannot debug this myself or make a fix for it, So it would be better if you posted the issue for the correct package if you can conclude if it is babel or some other package where the error originates.

[Mistrain-y-y]

I guess there's something wrong with ||，enum will be transform to Self-executing functions,before instrument:
var i: any = (e => (e[e.AA_BB_CC = 1] = "AA_BB_CC", e))(i || {});
but after instrument(i've removed some instrument code):
var i: any = (e => (e[e.AA_BB_CC = 1] = "AA_BB_CC", e))(i);

[kubmir]

I have the same issue after update to vite 6. Standard build without instrumentation works without any problem. However, once I add instrumentation it fails on the first enum in the codebase.

[sirphoenix]

This issue started for me in late december when vite updated to 6.0.5, however downgrading vite to 6.0.4 did not fix it.
Some other package sub-dependency must be the cause, but i'm unable to trace the package responsible.

If you run the example above with "VITE_COVERAGE=false" the error is fixed, so it absolutely is connected to istanbul or this plugin.

Can we at least move this to a discussion instead of just closing the bug?

[iFaxity]

@sirphoenix Sure thing, moving to a discussion.

[kubmir]

Hello guys, I have a (workaround) solution. It is caused by rollup - the latest version which works fine for me is 4.28.0. All version after this one makes my app crash when vite-plugin-istanbul is used. I enforced it in resolutions field of the package.json and I am fine again.

FYI: @sirphoenix @Mistrain-y-y @petertellgren

[sirphoenix]

This is it, thank you 👍
Since i'm using pnpm i used overrides in package.json

"pnpm": {
  "overrides": {
    "rollup": "4.28.1"
    }
  }

The bug was introduced in rollup v4.29.0, but it is only specified as a dependency in vite as "^4.23.0".
That is why it got upgraded when i did a "pnpm update" and could not be fixed by downgrading vite itself.

[sirphoenix]

Opened up a bug in rollup: rollup/rollup#5815