Skip to content

Missing openings #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
carmenfan opened this issue Jun 15, 2022 · 4 comments
Closed

Missing openings #230

carmenfan opened this issue Jun 15, 2022 · 4 comments

Comments

@carmenfan
Copy link

carmenfan commented Jun 15, 2022

Hi,

I'm trying to evaluate the library to replace IFCOpenShell and have come into a model where the wall isn't extruded for the windows:

image

what it looks like on BIM vision:
image

Model used: duplex.zip

I saw #210 and thought it might be related so I tried a range of epsilon values (1e-1 to 1e-15), and also retriangulating the mesh set as suggested here , but none of which has got me closer to what I want to see. So I started to wonder if it is not the same issue.

Any help/pointers would be much appreciated!

@ifcquery
Copy link
Owner

Hi,
I'm aware that the boolean operations with Carve have some issues.
I tried different epsilons, also normalizing the meshes before bool ops.
Doesn't work perfectly yet...
With some funding I could spend some time on improving the mesh quality by merging coplanar faces etc.

@carmenfan
Copy link
Author

@ifcquery thanks for your quick reply!

If the problem is on Carve, does that mean that I might be able to make it work if I recompile it with OpenCascade?

@ifcquery
Copy link
Owner

OpenCascade is not fully implemented in IFC++.
Meshes need to be converted to OCC in CSG_Adapter::computeCSG in case Carve fails.
Sometimes it is not possible to detect a failure in a CSG operation, the mesh is just not correct.

@ifcquery
Copy link
Owner

If you want, you cant contribute some implementations, but simply recompile with OCC won't do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants