(c2rust-analyze) Error immediately rather than continue and later error on global const refs.

kkysen · kkysen · commit bfde22e86f2b · 2023-04-24T18:44:52.000-04:00
diff --git a/c2rust-analyze/src/main.rs b/c2rust-analyze/src/main.rs
@@ -411,9 +411,10 @@ fn label_rvalue_tys<'tcx>(acx: &mut AnalysisCtxt<'_, 'tcx>, mir: &Body<'tcx>) {
                             acx.const_ref_locs.push(loc);
                             acx.assign_pointer_ids(ty)
                         }
-                        ConstantKind::Ty(_) => {
-                            // TODO: Handle global, named `const`s.
-                            continue;
+                        ConstantKind::Ty(ty) => {
+                            ::log::error!(
+                                "TODO: handle global, named `const` refs: {c:?}, ty = {ty:?}"
+                            );
                         }
                     }
                 }

Original file line number	Diff line number	Diff line change
`@@ -411,9 +411,10 @@ fn label_rvalue_tys<'tcx>(acx: &mut AnalysisCtxt<'_, 'tcx>, mir: &Body<'tcx>) {`
`411`	`411`	`acx.const_ref_locs.push(loc);`
`412`	`412`	`acx.assign_pointer_ids(ty)`
`413`	`413`	`}`
`414`		`- ConstantKind::Ty(_) => {`
`415`		- // TODO: Handle global, named `const`s.
`416`		`- continue;`
	`414`	`+ ConstantKind::Ty(ty) => {`
	`415`	`+ ::log::error!(`
	`416`	+ "TODO: handle global, named `const` refs: {c:?}, ty = {ty:?}"
	`417`	`+ );`
`417`	`418`	`}`
`418`	`419`	`}`
`419`	`420`	`}`