Skip to content

Commit ca5ccb8

Browse files
rockeetinikep
authored andcommitted
set m_read_opts.ignore_range_deletions properly (facebook#1218)
Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: facebook#1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb
1 parent bc2c16a commit ca5ccb8

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

storage/rocksdb/ha_rocksdb.cc

+10-1
Original file line numberDiff line numberDiff line change
@@ -4407,7 +4407,12 @@ class Rdb_transaction {
44074407
}
44084408

44094409
explicit Rdb_transaction(THD *const thd)
4410-
: m_thd(thd), m_tbl_io_perf(nullptr) {}
4410+
: m_thd(thd), m_tbl_io_perf(nullptr) {
4411+
m_read_opts[INTRINSIC_TMP].ignore_range_deletions =
4412+
!rocksdb_enable_delete_range_for_drop_index;
4413+
m_read_opts[USER_TABLE].ignore_range_deletions =
4414+
!rocksdb_enable_delete_range_for_drop_index;
4415+
}
44114416

44124417
virtual ~Rdb_transaction() {
44134418
#ifndef NDEBUG
@@ -4859,6 +4864,8 @@ class Rdb_transaction_impl : public Rdb_transaction {
48594864
m_rocksdb_reuse_tx[table_type] = nullptr;
48604865

48614866
m_read_opts[table_type] = rocksdb::ReadOptions();
4867+
m_read_opts[table_type].ignore_range_deletions =
4868+
!rocksdb_enable_delete_range_for_drop_index;
48624869

48634870
set_initial_savepoint();
48644871

@@ -4983,6 +4990,8 @@ class Rdb_writebatch_impl : public Rdb_transaction {
49834990
void reset() {
49844991
m_batch->Clear();
49854992
m_read_opts[USER_TABLE] = rocksdb::ReadOptions();
4993+
m_read_opts[USER_TABLE].ignore_range_deletions =
4994+
!rocksdb_enable_delete_range_for_drop_index;
49864995
m_ddl_transaction = false;
49874996
}
49884997

0 commit comments

Comments
 (0)