Skip to content

Signed Document non recognisable header fields capturing #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 task done
Mr-Leshiy opened this issue May 13, 2025 · 2 comments · May be fixed by #322
Open
1 task done

Signed Document non recognisable header fields capturing #316

Mr-Leshiy opened this issue May 13, 2025 · 2 comments · May be fixed by #322
Assignees
@no30bit
Labels
bug Something isn't working F14-RC2

Comments

@Mr-Leshiy
Copy link
Contributor

Mr-Leshiy commented May 13, 2025 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

CatalystSignedDocument structure is focusing on only the known metadata fields like id, ver, type etc. and any other fields just being skipped during the decoding procedure, meaning that such document considered valid.
Which is wrong.

Expected Behavior

For any unsupported/un recognisable metadata field and signatures protected and unprotected header fields we should invalid it by adding error message into the report.
@Mr-Leshiy Mr-Leshiy added the bug Something isn't working label May 13, 2025
@Mr-Leshiy Mr-Leshiy self-assigned this May 13, 2025
@Mr-Leshiy Mr-Leshiy moved this from New to 🔖 Ready in Catalyst May 13, 2025
@stevenj
Copy link
Collaborator

stevenj commented May 13, 2025

No, only metadata defined for any particular document should be present. Extra protected metadata is invalid.
Unprotected metadata has no impact on signatures, and can be ignored. It also does not need to be preserved if present.

@Mr-Leshiy
Copy link
Contributor Author

@stevenj updated description.

@no30bit no30bit moved this from 🔖 Ready to 🏗 In progress in Catalyst May 14, 2025
@no30bit no30bit linked a pull request May 14, 2025 that will close this issue
Draft
8 tasks
@no30bit no30bit moved this from 🏗 In progress to 👀 In review in Catalyst May 14, 2025
@no30bit no30bit moved this from 👀 In review to 🛑 Blocked in Catalyst May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@no30bit no30bit

Labels
bug Something isn't working F14-RC2
Projects
Catalyst
Status: 🛑 Blocked
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(rust/signed-doc): check protected metadata field support input-output-hk/catalyst-libs
4 participants
@stevenj @ArturWieczorek @Mr-Leshiy @no30bit