Open
Description
Don't let me hold anything up in this space, but one thing to consider for Windows-specific precommit testing is to build a debug configuration so that we get checked & debug iterator testing (https://learn.microsoft.com/en-us/cpp/standard-library/safe-libraries-cpp-standard-library?view=msvc-170). That helps catch quite a few mistakes (I just fixed one this morning that turned out to be A.find(X) != B.end()
where A
and B
are the same type but different objects -- MSVC debug iterators caught the issue immediately).
Originally posted by @AaronBallman in #8980 (comment)