From ec196e3521d4b584231a2e7e10857f34ffbf130c Mon Sep 17 00:00:00 2001 From: Explorer / <39474131+open-source-explorer@users.noreply.github.com> Date: Fri, 18 Jan 2019 08:28:57 +0530 Subject: [PATCH 1/3] Valiate arguments --- src/executables/uber.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/executables/uber.js b/src/executables/uber.js index 5d1c1aa..3dc2bf1 100644 --- a/src/executables/uber.js +++ b/src/executables/uber.js @@ -8,4 +8,10 @@ program.version(pkg.version) .description('Figure out if you should order a car to pick you up and drive you to where you want to go') .command('price', 'get price estimate') .command('time', 'get time to pickup estimate') + .arguments('') + .action((cmd) => { + program.outputHelp(); + console.log(`\n Unknown command ${cmd}.`)); + console.log(); + }); .parse(process.argv); From f0ac075891a16d712732033491aefdc05a08134d Mon Sep 17 00:00:00 2001 From: Explorer / <39474131+open-source-explorer@users.noreply.github.com> Date: Fri, 18 Jan 2019 08:33:30 +0530 Subject: [PATCH 2/3] minor fix --- src/executables/uber.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/executables/uber.js b/src/executables/uber.js index 3dc2bf1..1db95b4 100644 --- a/src/executables/uber.js +++ b/src/executables/uber.js @@ -13,5 +13,5 @@ program.version(pkg.version) program.outputHelp(); console.log(`\n Unknown command ${cmd}.`)); console.log(); - }); + }) .parse(process.argv); From 01dcd745abf29020e9eff9501ccc8d878176cc0a Mon Sep 17 00:00:00 2001 From: Explorer / <39474131+open-source-explorer@users.noreply.github.com> Date: Tue, 7 Apr 2020 21:25:14 +0530 Subject: [PATCH 3/3] fix: regression --- src/executables/uber.js | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/executables/uber.js b/src/executables/uber.js index 1db95b4..f74d185 100644 --- a/src/executables/uber.js +++ b/src/executables/uber.js @@ -9,9 +9,8 @@ program.version(pkg.version) .command('price', 'get price estimate') .command('time', 'get time to pickup estimate') .arguments('') - .action((cmd) => { - program.outputHelp(); - console.log(`\n Unknown command ${cmd}.`)); - console.log(); - }) + .action((cmd) => { + program.outputHelp(); + console.log(`\n Unknown command ${cmd}.`); + }) .parse(process.argv);