Skip to content

Byte code got decompiled properly by Luyten #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
svaningelgem opened this issue Feb 25, 2021 · 0 comments
Open

Byte code got decompiled properly by Luyten #54

svaningelgem opened this issue Feb 25, 2021 · 0 comments

Comments

@svaningelgem
Copy link

Hi,

Just something I noticed was done better in Luyten:

JD Gui got this result:

    public static a adliuazd(IBinder param1IBinder) {
      // Byte code:
      //   0: bipush #18
      //   2: bipush #32
      //   4: iadd
      //   5: bipush #32
      //   7: irem
      //   8: ifgt -> 14
      //   11: goto -> 52
      //   14: aload_0
      //   15: ifnonnull -> 20
      //   18: aconst_null
      //   19: areturn
      //   20: aload_0
      //   21: ldc 'android.support.v4.app.INotificationSideChannel'
      //   23: invokestatic qskduaozie : (Landroid/os/IBinder;Ljava/lang/String;)Landroid/os/IInterface;
      //   26: astore_1
      //   27: aload_1
      //   28: ifnull -> 43
      //   31: aload_1
      //   32: instanceof a/a/a/a/a
      //   35: ifeq -> 43
      //   38: aload_1
      //   39: checkcast a/a/a/a/a
      //   42: areturn
      //   43: new a/a/a/a/a$a$a
      //   46: dup
      //   47: aload_0
      //   48: invokespecial <init> : (Landroid/os/IBinder;)V
      //   51: areturn
      //   52: goto -> 14
    }

While Luyten got this result:

            final IInterface qskduaozie = qskduaozie(binder, "android.support.v4.app.INotificationSideChannel");
            if (qskduaozie != null && qskduaozie instanceof a) {
                return (a)qskduaozie;
            }
            return new a(binder);

Maybe something to improve on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant