Skip to content

Commit fc5da65

Browse files
committed
change default buttons to btn-light
1 parent 287b9fa commit fc5da65

File tree

7 files changed

+18
-18
lines changed

7 files changed

+18
-18
lines changed

README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ generates a form group, with two buttons: Save (a dropdown menu, that includes '
9292
<button type='submit' name='next_action' class='dropdown-item submitbar-new' value='new'>Save and new</button>
9393
</div>
9494
</div>
95-
<a class="btn btn-default submitbar-cancel" rel="nofollow" href="/things">Cancel</a>
95+
<a class="btn btn-light submitbar-cancel" rel="nofollow" href="/things">Cancel</a>
9696
</div>
9797
</div>
9898
```
@@ -152,7 +152,7 @@ This is the actual code of the default partial (located in app/views/bootstrap_f
152152
<%= link_to text, url, options %>
153153
<% end %>
154154
<% if show_cancel_button %>
155-
<%= link_to cancel_button_text, cancel_button_url, class: "btn btn-default submitbar-cancel", rel: "nofollow" %>
155+
<%= link_to cancel_button_text, cancel_button_url, class: "btn btn-light submitbar-cancel", rel: "nofollow" %>
156156
<% end %>
157157
</div>
158158
<% if right_buttons.any? %>

app/assets/javascripts/bootstrap_form_extensions/scheduler.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@
139139
" <div class='modal-body'>" + this.scheduleTable() + this.linksAllNone() + "</div>" +
140140
" <div class='modal-footer'>" +
141141
" <button class='btn btn-primary apply' type='button' data-dismiss='modal'>Apply</button>" +
142-
" <button class='btn btn-default cancel' type='button' data-dismiss='modal'>Cancel</button>" +
142+
" <button class='btn btn-light cancel' type='button' data-dismiss='modal'>Cancel</button>" +
143143
" </div>" +
144144
" </div>" +
145145
" </div>" +

app/views/bootstrap_form_extensions/_submit_bar.html.erb

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
<%= link_to text, url, options %>
2929
<% end %>
3030
<% if show_cancel_button %>
31-
<%= link_to cancel_button_text, cancel_button_url, class: 'btn btn-default submitbar-cancel', rel: 'nofollow' %>
31+
<%= link_to cancel_button_text, cancel_button_url, class: 'btn btn-light submitbar-cancel', rel: 'nofollow' %>
3232
<% end %>
3333
</div>
3434
<% if right_buttons.any? %>

lib/bootstrap_form_extensions/submit_bar.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ def parse_extra_buttons_for_submit_bar buttons, type
5454
buttons.map do |options|
5555
text = options.delete :text
5656
url = options.delete :url
57-
options[:class] = merge_css_classes 'btn', 'btn-default', "submitbar-#{type}-button", options[:class]
57+
options[:class] = merge_css_classes 'btn', 'btn-light', "submitbar-#{type}-button", options[:class]
5858
options[:rel] ||= "nofollow"
5959
{ text: text, url: url, options: options }
6060
end

test/arrayed_field_test.rb

+8-8
Original file line numberDiff line numberDiff line change
@@ -8,22 +8,22 @@ def setup
88
end
99

1010
test "arrayed_text_field with default values" do
11-
expected = '<div class="form-group"><label class="control-label col-2" for="thing_list">List</label><div class="col-10"><div data-arrayed-field="true"><div class="blueprint-for-arrayed-field" style="display:none;"><div class="row mt-1"><div class="col-11"><input type="text" id="" class="form-control" data-name="thing[list][]" /></div><div class="col-1"><a class="btn btn-default remove-arrayed-field-row" href="javascript:void(0);">&times;</a></div></div></div><div class="arrayed-field-rows"><div class="row mt-1"><div class="col-11"><input type="text" name="thing[list][]" id="thing_list_" value="One" class="form-control" /></div><div class="col-1"><a class="btn btn-default remove-arrayed-field-row" href="javascript:void(0);">&times;</a></div></div><div class="row mt-1"><div class="col-11"><input type="text" name="thing[list][]" id="thing_list_" value="Two" class="form-control" /></div><div class="col-1"><a class="btn btn-default remove-arrayed-field-row" href="javascript:void(0);">&times;</a></div></div></div><div class="row mt-1"><div class="col-12"><a class="btn btn-default add-arrayed-field-row" href="javascript:void(0);">+</a></div></div></div></div></div>'
11+
expected = '<div class="form-group"><label class="control-label col-2" for="thing_list">List</label><div class="col-10"><div data-arrayed-field="true"><div class="blueprint-for-arrayed-field" style="display:none;"><div class="row mt-1"><div class="col-11"><input type="text" id="" class="form-control" data-name="thing[list][]" /></div><div class="col-1"><a class="btn btn-light remove-arrayed-field-row" href="javascript:void(0);">&times;</a></div></div></div><div class="arrayed-field-rows"><div class="row mt-1"><div class="col-11"><input type="text" name="thing[list][]" id="thing_list_" value="One" class="form-control" /></div><div class="col-1"><a class="btn btn-light remove-arrayed-field-row" href="javascript:void(0);">&times;</a></div></div><div class="row mt-1"><div class="col-11"><input type="text" name="thing[list][]" id="thing_list_" value="Two" class="form-control" /></div><div class="col-1"><a class="btn btn-light remove-arrayed-field-row" href="javascript:void(0);">&times;</a></div></div></div><div class="row mt-1"><div class="col-12"><a class="btn btn-light add-arrayed-field-row" href="javascript:void(0);">+</a></div></div></div></div></div>'
1212
assert_equal expected, @builder.arrayed_text_field(:list)
1313
end
1414

1515
test "arrayed_url_field with default values" do
16-
expected = '<div class="form-group"><label class="control-label col-2" for="thing_urls">Urls</label><div class="col-10"><div data-arrayed-field="true"><div class="blueprint-for-arrayed-field" style="display:none;"><div class="row mt-1"><div class="col-11"><input type="url" id="" class="form-control" data-name="thing[urls][]" /></div><div class="col-1"><a class="btn btn-default remove-arrayed-field-row" href="javascript:void(0);">&times;</a></div></div></div><div class="arrayed-field-rows"><div class="row mt-1"><div class="col-11"><input type="url" name="thing[urls][]" id="thing_urls_" value="www.example1.com" class="form-control" /></div><div class="col-1"><a class="btn btn-default remove-arrayed-field-row" href="javascript:void(0);">&times;</a></div></div><div class="row mt-1"><div class="col-11"><input type="url" name="thing[urls][]" id="thing_urls_" value="www.example2.com" class="form-control" /></div><div class="col-1"><a class="btn btn-default remove-arrayed-field-row" href="javascript:void(0);">&times;</a></div></div></div><div class="row mt-1"><div class="col-12"><a class="btn btn-default add-arrayed-field-row" href="javascript:void(0);">+</a></div></div></div></div></div>'
16+
expected = '<div class="form-group"><label class="control-label col-2" for="thing_urls">Urls</label><div class="col-10"><div data-arrayed-field="true"><div class="blueprint-for-arrayed-field" style="display:none;"><div class="row mt-1"><div class="col-11"><input type="url" id="" class="form-control" data-name="thing[urls][]" /></div><div class="col-1"><a class="btn btn-light remove-arrayed-field-row" href="javascript:void(0);">&times;</a></div></div></div><div class="arrayed-field-rows"><div class="row mt-1"><div class="col-11"><input type="url" name="thing[urls][]" id="thing_urls_" value="www.example1.com" class="form-control" /></div><div class="col-1"><a class="btn btn-light remove-arrayed-field-row" href="javascript:void(0);">&times;</a></div></div><div class="row mt-1"><div class="col-11"><input type="url" name="thing[urls][]" id="thing_urls_" value="www.example2.com" class="form-control" /></div><div class="col-1"><a class="btn btn-light remove-arrayed-field-row" href="javascript:void(0);">&times;</a></div></div></div><div class="row mt-1"><div class="col-12"><a class="btn btn-light add-arrayed-field-row" href="javascript:void(0);">+</a></div></div></div></div></div>'
1717
assert_equal expected, @builder.arrayed_url_field(:urls)
1818
end
1919

2020
test "ArrayedField, with nonexistent attribute, assumes the value is an empty array" do
21-
expected = '<div class="form-group"><label class="control-label col-2" for="thing_nonexistent">Nonexistent</label><div class="col-10"><div data-arrayed-field="true"><div class="blueprint-for-arrayed-field" style="display:none;"><div class="row mt-1"><div class="col-11"><input type="text" id="" class="form-control" data-name="thing[nonexistent][]" /></div><div class="col-1"><a class="btn btn-default remove-arrayed-field-row" href="javascript:void(0);">&times;</a></div></div></div><div class="arrayed-field-rows"></div><div class="row mt-1"><div class="col-12"><a class="btn btn-default add-arrayed-field-row" href="javascript:void(0);">+</a></div></div></div></div></div>'
21+
expected = '<div class="form-group"><label class="control-label col-2" for="thing_nonexistent">Nonexistent</label><div class="col-10"><div data-arrayed-field="true"><div class="blueprint-for-arrayed-field" style="display:none;"><div class="row mt-1"><div class="col-11"><input type="text" id="" class="form-control" data-name="thing[nonexistent][]" /></div><div class="col-1"><a class="btn btn-light remove-arrayed-field-row" href="javascript:void(0);">&times;</a></div></div></div><div class="arrayed-field-rows"></div><div class="row mt-1"><div class="col-12"><a class="btn btn-light add-arrayed-field-row" href="javascript:void(0);">+</a></div></div></div></div></div>'
2222
assert_equal expected, @builder.arrayed_text_field(:nonexistent)
2323
end
2424

2525
test "ArrayedField, with non-array attribute, assumes the value is an empty array" do
26-
expected = '<div class="form-group"><label class="control-label col-2 required" for="thing_name">Name</label><div class="col-10"><div data-arrayed-field="true"><div class="blueprint-for-arrayed-field" style="display:none;"><div class="row mt-1"><div class="col-11"><input type="text" id="" class="form-control" data-name="thing[name][]" /></div><div class="col-1"><a class="btn btn-default remove-arrayed-field-row" href="javascript:void(0);">&times;</a></div></div></div><div class="arrayed-field-rows"></div><div class="row mt-1"><div class="col-12"><a class="btn btn-default add-arrayed-field-row" href="javascript:void(0);">+</a></div></div></div></div></div>'
26+
expected = '<div class="form-group"><label class="control-label col-2 required" for="thing_name">Name</label><div class="col-10"><div data-arrayed-field="true"><div class="blueprint-for-arrayed-field" style="display:none;"><div class="row mt-1"><div class="col-11"><input type="text" id="" class="form-control" data-name="thing[name][]" /></div><div class="col-1"><a class="btn btn-light remove-arrayed-field-row" href="javascript:void(0);">&times;</a></div></div></div><div class="arrayed-field-rows"></div><div class="row mt-1"><div class="col-12"><a class="btn btn-light add-arrayed-field-row" href="javascript:void(0);">+</a></div></div></div></div></div>'
2727
assert_equal expected, @builder.arrayed_text_field(:name)
2828
end
2929

@@ -33,19 +33,19 @@ def setup
3333
end
3434

3535
test "arrayed_json_field with default values" do
36-
expected = '<div class="form-group"><label class="control-label col-2" for="thing_variables">Variables</label><div class="col-10"><div data-arrayed-field="true"><div class="blueprint-for-arrayed-field" style="display:none;"><div class="row mt-1"><div class="col-2"><input type="text" id="" class="form-control" placeholder="name" data-name="thing[variables][][name]" /></div><div class="col-2"><input type="text" id="" class="form-control" placeholder="value" data-name="thing[variables][][value]" /></div><div class="col-1"><a class="btn btn-default remove-arrayed-field-row" href="javascript:void(0);">&times;</a></div></div></div><div class="arrayed-field-rows"><div class="row mt-1"><div class="col-2"><input type="text" name="thing[variables][][name]" id="thing_variables__name" class="form-control" placeholder="name" /></div><div class="col-2"><input type="text" name="thing[variables][][value]" id="thing_variables__value" class="form-control" placeholder="value" /></div><div class="col-1"><a class="btn btn-default remove-arrayed-field-row" href="javascript:void(0);">&times;</a></div></div><div class="row mt-1"><div class="col-2"><input type="text" name="thing[variables][][name]" id="thing_variables__name" class="form-control" placeholder="name" /></div><div class="col-2"><input type="text" name="thing[variables][][value]" id="thing_variables__value" class="form-control" placeholder="value" /></div><div class="col-1"><a class="btn btn-default remove-arrayed-field-row" href="javascript:void(0);">&times;</a></div></div></div><div class="row mt-1"><div class="col-12"><a class="btn btn-default add-arrayed-field-row" href="javascript:void(0);">+</a></div></div></div></div></div>'
36+
expected = '<div class="form-group"><label class="control-label col-2" for="thing_variables">Variables</label><div class="col-10"><div data-arrayed-field="true"><div class="blueprint-for-arrayed-field" style="display:none;"><div class="row mt-1"><div class="col-2"><input type="text" id="" class="form-control" placeholder="name" data-name="thing[variables][][name]" /></div><div class="col-2"><input type="text" id="" class="form-control" placeholder="value" data-name="thing[variables][][value]" /></div><div class="col-1"><a class="btn btn-light remove-arrayed-field-row" href="javascript:void(0);">&times;</a></div></div></div><div class="arrayed-field-rows"><div class="row mt-1"><div class="col-2"><input type="text" name="thing[variables][][name]" id="thing_variables__name" class="form-control" placeholder="name" /></div><div class="col-2"><input type="text" name="thing[variables][][value]" id="thing_variables__value" class="form-control" placeholder="value" /></div><div class="col-1"><a class="btn btn-light remove-arrayed-field-row" href="javascript:void(0);">&times;</a></div></div><div class="row mt-1"><div class="col-2"><input type="text" name="thing[variables][][name]" id="thing_variables__name" class="form-control" placeholder="name" /></div><div class="col-2"><input type="text" name="thing[variables][][value]" id="thing_variables__value" class="form-control" placeholder="value" /></div><div class="col-1"><a class="btn btn-light remove-arrayed-field-row" href="javascript:void(0);">&times;</a></div></div></div><div class="row mt-1"><div class="col-12"><a class="btn btn-light add-arrayed-field-row" href="javascript:void(0);">+</a></div></div></div></div></div>'
3737
assert_equal expected, @builder.arrayed_json_field(:variables, %i[ name value ])
3838
end
3939

4040
test "arrayed_json_field with custom input types" do
4141
expected = <<-HTML.chomp
4242
<div class="form-group"><label class="control-label col-2" for="thing_variables">Variables</label><div class="col-10"><div data-arrayed-field="true"><div class="blueprint-for-arrayed-field" style="display:none;"><div class="row mt-1"><div class="col-2"><select id="" class="form-control" data-name="thing[variables][][name]"><option value="var1">Variable One</option>
4343
<option value="var2">Variable Two</option>
44-
<option value="var3">Variable Three</option></select></div><div class="col-2"><input type="text" id="" class="form-control" placeholder="value" data-name="thing[variables][][value]" /></div><div class="col-1"><a class="btn btn-default remove-arrayed-field-row" href="javascript:void(0);">&times;</a></div></div></div><div class="arrayed-field-rows"><div class="row mt-1"><div class="col-2"><select name="thing[variables][][name]" id="thing_variables__name" class="form-control"><option value="var1">Variable One</option>
44+
<option value="var3">Variable Three</option></select></div><div class="col-2"><input type="text" id="" class="form-control" placeholder="value" data-name="thing[variables][][value]" /></div><div class="col-1"><a class="btn btn-light remove-arrayed-field-row" href="javascript:void(0);">&times;</a></div></div></div><div class="arrayed-field-rows"><div class="row mt-1"><div class="col-2"><select name="thing[variables][][name]" id="thing_variables__name" class="form-control"><option value="var1">Variable One</option>
4545
<option value="var2">Variable Two</option>
46-
<option value="var3">Variable Three</option></select></div><div class="col-2"><input type="text" name="thing[variables][][value]" id="thing_variables__value" class="form-control" placeholder="value" /></div><div class="col-1"><a class="btn btn-default remove-arrayed-field-row" href="javascript:void(0);">&times;</a></div></div><div class="row mt-1"><div class="col-2"><select name="thing[variables][][name]" id="thing_variables__name" class="form-control"><option value="var1">Variable One</option>
46+
<option value="var3">Variable Three</option></select></div><div class="col-2"><input type="text" name="thing[variables][][value]" id="thing_variables__value" class="form-control" placeholder="value" /></div><div class="col-1"><a class="btn btn-light remove-arrayed-field-row" href="javascript:void(0);">&times;</a></div></div><div class="row mt-1"><div class="col-2"><select name="thing[variables][][name]" id="thing_variables__name" class="form-control"><option value="var1">Variable One</option>
4747
<option value="var2">Variable Two</option>
48-
<option value="var3">Variable Three</option></select></div><div class="col-2"><input type="text" name="thing[variables][][value]" id="thing_variables__value" class="form-control" placeholder="value" /></div><div class="col-1"><a class="btn btn-default remove-arrayed-field-row" href="javascript:void(0);">&times;</a></div></div></div><div class="row mt-1"><div class="col-12"><a class="btn btn-default add-arrayed-field-row" href="javascript:void(0);">+</a></div></div></div></div></div>
48+
<option value="var3">Variable Three</option></select></div><div class="col-2"><input type="text" name="thing[variables][][value]" id="thing_variables__value" class="form-control" placeholder="value" /></div><div class="col-1"><a class="btn btn-light remove-arrayed-field-row" href="javascript:void(0);">&times;</a></div></div></div><div class="row mt-1"><div class="col-12"><a class="btn btn-light add-arrayed-field-row" href="javascript:void(0);">+</a></div></div></div></div></div>
4949
HTML
5050
assert_equal expected, @builder.arrayed_json_field(:variables, [ { name: { type: :select, options: options_for_variables } }, :value ])
5151
end

test/javascripts/arrayed_field_spec.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ describe("ArrayedField", function() {
4545
+' <input type="url" id="" class="form-control" data-name="thing[urls][]" />'
4646
+' </div>'
4747
+' <div class="col-1">'
48-
+' <a class="btn btn-default remove-arrayed-field-row" href="javascript:void(0);">&times;</a>'
48+
+' <a class="btn btn-light remove-arrayed-field-row" href="javascript:void(0);">&times;</a>'
4949
+' </div>'
5050
+' </div>'
5151
+' </div>'
@@ -55,21 +55,21 @@ describe("ArrayedField", function() {
5555
+' <input type="url" id="" class="form-control" name="thing[urls][]" />'
5656
+' </div>'
5757
+' <div class="col-1">'
58-
+' <a class="btn btn-default remove-arrayed-field-row" href="javascript:void(0);">&times;</a>'
58+
+' <a class="btn btn-light remove-arrayed-field-row" href="javascript:void(0);">&times;</a>'
5959
+' </div>'
6060
+' </div>'
6161
+' <div class="row mt-1">'
6262
+' <div class="col-11">'
6363
+' <input type="url" id="" class="form-control" name="thing[urls][]" />'
6464
+' </div>'
6565
+' <div class="col-1">'
66-
+' <a class="btn btn-default remove-arrayed-field-row" href="javascript:void(0);">&times;</a>'
66+
+' <a class="btn btn-light remove-arrayed-field-row" href="javascript:void(0);">&times;</a>'
6767
+' </div>'
6868
+' </div>'
6969
+' </div>'
7070
+' <div class="row mt-1">'
7171
+' <div class="col-12">'
72-
+' <a class="btn btn-default add-arrayed-field-row" href="javascript:void(0);">+</a>'
72+
+' <a class="btn btn-light add-arrayed-field-row" href="javascript:void(0);">+</a>'
7373
+' </div>'
7474
+' </div>'
7575
+'</div>'

test/submit_bar_test.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def setup
2727
</button>
2828
</div>
2929
</div>
30-
<a class="btn btn-default submitbar-cancel" rel="nofollow" href="/things">Cancel</a>
30+
<a class="btn btn-light submitbar-cancel" rel="nofollow" href="/things">Cancel</a>
3131
</div>
3232
</div>
3333
HTML

0 commit comments

Comments
 (0)