Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Languages missing from app settings #1327

Open
felix920506 opened this issue Nov 25, 2024 · 1 comment · Fixed by #1417
Open

Languages missing from app settings #1327

felix920506 opened this issue Nov 25, 2024 · 1 comment · Fixed by #1417
Labels
bug Something isn't working

Comments

@felix920506
Copy link
Member

felix920506 commented Nov 25, 2024

Describe the bug

Description:

Some languages that are in the Swiftfin weblate are not present in the language settings of the app. For example Traditional Chinese, Dutch, Ukrainian

Reproduction Steps:

  1. Download Swiftfin on App store
  2. Start Swiftfin for the first time
  3. Leave swiftfin and go to settings app, find swiftfin and select language
  4. See error

Application version

1.2

Where did you install the app from?

App Store

Device information

iPad Pro 2021

OS version

iPadOS 17.5.1

Jellyfin server version

Server is not required for reproduction of this issue

@felix920506 felix920506 added the bug Something isn't working label Nov 25, 2024
@samglt
Copy link
Contributor

samglt commented Jan 30, 2025

Looks like many languages are in the repo but haven't been added to the Xcode project. I'll submit a PR later today.

Given that there are 46 languages in the repo and only 16 of them are actually user accessible, I think there should at least be some documentation somewhere saying to remember to add new localizations in Xcode when merging new translations from Weblate.

I'm not sure how practical this would be to automate since it involves the .xcodeproj file but it would be nice if it was

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants