Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore essential npm scripts #248

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Restore essential npm scripts #248

wants to merge 2 commits into from
+25 −22

Conversation

cewert
Copy link
Member

@cewert cewert commented Apr 3, 2025

Changes

  • Restore essential NPM scripts that were removed from the new viv repo that was brought over starting in version 3.0.0
  • npm run format to fix all formatting issues found (it alphabetized the list of imports at the top of all bs files)

Issues

Fixes #247

@cewert cewert requested a review from a team as a code owner April 3, 2025 13:57
TwitchBronBron
TwitchBronBron approved these changes Apr 3, 2025
View reviewed changes
Copy link
Contributor

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think these types of coding standards are extremely important in community-based projects, so I'm glad to see these getting added back.

@cewert
Copy link
Member Author

cewert commented Apr 3, 2025

Forgot to mention, there was no need to restore or reconfigure the bsfmt.json config file because the file still exists in master https://github.com/jellyfin/jellyfin-roku/blob/master/bsfmt.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwitchBronBron TwitchBronBron TwitchBronBron approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Essential npm scripts missing
2 participants
@cewert @TwitchBronBron