Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Essential npm scripts missing #247

Open
cewert opened this issue Apr 3, 2025 · 0 comments · May be fixed by #248
Open

Essential npm scripts missing #247

cewert opened this issue Apr 3, 2025 · 0 comments · May be fixed by #248
Labels
bug Something isn't working

Comments

@cewert
Copy link
Member

cewert commented Apr 3, 2025 •
edited
Loading

jellyfin-roku v3.0, aka the new viv repo, is missing some essential npm scripts:

  • validate
  • check-formatting
  • format

These are used by devs to validate the app builds correctly and to write better code. They were part of our app for years before the viv repo was brought over. I have no idea what possible upside there could be to removing them and there is no downside to adding them back

commit they were added back in 2021: ecf4090

commit they were removed: 7c68c73 61a94de
@cewert cewert added the bug Something isn't working label Apr 3, 2025
@cewert cewert linked a pull request Apr 3, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore essential npm scripts cewert/viv
1 participant
@cewert