Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile missing #250

Open
cewert opened this issue Apr 3, 2025 · 1 comment
Open

Makefile missing #250

cewert opened this issue Apr 3, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@cewert
Copy link
Member

cewert commented Apr 3, 2025

Another thing that has been removed in the viv repo since the fork is the makefile. Was there a reason for this? Was it not working correctly anymore or what's the story?

The makefile has been with us since basically the very beginning. It was made by @bisby, the guy who bootstrapped our app, back in 2019. It was still working correctly last I tested when it was updated recently in Oct 2023.

Our app has users that depend on this file. We have had some devs over the years who only use the makefile instead of vscode. What benefit is there to removing it from our repo???

@cewert cewert added the bug Something isn't working label Apr 3, 2025
@cewert
Copy link
Member Author

cewert commented Apr 3, 2025

Took me a while but I found the commit where the makefile was removed. It was right after the viv fork was created just before the v1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant