Skip to content

windows doesn't respect the shell #4630

Open
@melMass

Description

@melMass

Describe the bug
Unlike on macos where nushell works fine, windows is hardcoded to use cmd

To Reproduce
I discovered it here: #4047 (comment)
It wasn't obvious at first but after debugging it I realised it was using cmd /c despite $env.SHELL being set.
Then I tracked it back to #4385 and discovered the hardcoded case for windows.

Expected behavior
To work as other os, I specifically use nushell because of how powerful it is at being cross platform.

Ultimately for me this whole shell thing shouldn't be hardcoded or only fallbacks and expose both as options

Version info:
No sure why but building from master I only get:

commit=, build date=, build source=unknown, version=unversioned, os=windows, arch=amd64, git version=2.49.0.windows.1

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions