Fix RabbitMQ README #19
Conversation
The RabbitMQ plugin sets the `$RABBITMQ_CONFIG_FILES` environment variable, not `$RABBITMQ_CONFIG_FILE`, as shown in `rabbitmq/plugin.json:6`.[1] Both variables are documented in the official RabbitMQ Environment Variables guide.[2] [1] https://github.com/jetify-com/devbox-plugins/blob/4aab8235eb412ff6997900969aed64158c4497c8/rabbitmq/plugin.json#L6 [2] https://www.rabbitmq.com/docs/relocate#environment-variables
There was a problem hiding this comment.
RABBITMQ_CONFIG_FILE is also part of the documentation. Leaning towards not fix
|
I don't understand why not fix it. Devbox plugins documentation is incorrect. It says that it sets the devbox-plugins/rabbitmq/README.md Line 35 in dc28e6a It actually sets RABBITMQ_CONFIG_FILES (with "S" suffix). devbox-plugins/rabbitmq/plugin.json Line 6 in dc28e6a While RabbitMQ defines both configuration variables, each has a different purpose:
As RabbitMQ documentation says in The Main Configuration File, rabbitmq.conf chapter's last paragraph:
and in Using a Directory of .conf Files chapter's first paragraph:
Previously referenced documentation chapter Environment Variables also states differences between Devbox plugin only sets the This is basically just a typo in documentation. Edit: Changed links to GitHub style to show code previews. |
|
@och42 I have misunderstood your message. Thanks for clarifying! |
The RabbitMQ plugin sets the
$RABBITMQ_CONFIG_FILESenvironment variable, not$RABBITMQ_CONFIG_FILE, as shown inrabbitmq/plugin.json:6.[1]Both variables are documented in the official RabbitMQ Environment Variables guide.[2]
[1]
devbox-plugins/rabbitmq/plugin.json
Line 6 in 4aab823
[2] https://www.rabbitmq.com/docs/relocate#environment-variables