binding: fix double reference clone warnings

example warning:

warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type
   --> pulse-binding/src/context/ext_device_manager.rs:201:44
    |
201 |             c_devs.push(CString::new(device.clone()).unwrap());
    |                                            ^^^^^^^^
    |
    = note: `#[warn(suspicious_double_ref_op)]` on by default

Author: jnqnfe

pulse-binding/CHANGELOG.md

@@ -1,5 +1,6 @@
 # unreleased]
 
+ * Fixed 'double-reference clone' warnings.
  * Dropped PA v4 support.
 
 # 2.27.1 (January 9th, 2023)

pulse-binding/src/context/ext_device_manager.rs

@@ -198,7 +198,7 @@ impl DeviceManager {
         // as_ptr() giving dangling pointers!
         let mut c_devs: Vec<CString> = Vec::with_capacity(devices.len());
         for device in devices {
-            c_devs.push(CString::new(device.clone()).unwrap());
+            c_devs.push(CString::new(*device).unwrap());
         }
 
         // Capture array of pointers to the above CString values.
@@ -246,7 +246,7 @@ impl DeviceManager {
         let c_role = CString::new(role.clone()).unwrap();
         let mut c_devs: Vec<CString> = Vec::with_capacity(devices.len());
         for device in devices {
-            c_devs.push(CString::new(device.clone()).unwrap());
+            c_devs.push(CString::new(*device).unwrap());
         }
 
         // Capture array of pointers to the above CString values.

pulse-binding/src/context/ext_stream_restore.rs

@@ -156,7 +156,7 @@ impl StreamRestore {
         // as_ptr() giving dangling pointers!
         let mut c_streams: Vec<CString> = Vec::with_capacity(streams.len());
         for stream in streams {
-            c_streams.push(CString::new(stream.clone()).unwrap());
+            c_streams.push(CString::new(*stream).unwrap());
         }
 
         // Capture array of pointers to the above CString values.

pulse-binding/src/context/mod.rs

@@ -507,7 +507,7 @@ impl Context {
         // as_ptr() giving dangling pointers!
         let mut c_keys: Vec<CString> = Vec::with_capacity(keys.len());
         for key in keys {
-            c_keys.push(CString::new(key.clone()).unwrap());
+            c_keys.push(CString::new(*key).unwrap());
         }
 
         // Capture array of pointers to the above CString values.

pulse-binding/src/format.rs

@@ -526,7 +526,7 @@ impl Info {
         let c_key = CString::new(key.clone()).unwrap();
         let mut c_values: Vec<CString> = Vec::with_capacity(values.len());
         for v in values {
-            c_values.push(CString::new(v.clone()).unwrap());
+            c_values.push(CString::new(*v).unwrap());
         }
 
         // Capture array of pointers to the above CString values

pulse-binding/src/proplist.rs

@@ -372,7 +372,7 @@ impl Proplist {
         // as_ptr() giving dangling pointers!
         let mut c_keys: Vec<CString> = Vec::with_capacity(keys.len());
         for k in keys {
-            c_keys.push(CString::new(k.clone()).unwrap());
+            c_keys.push(CString::new(*k).unwrap());
         }
 
         // Capture array of pointers to the above CString values.

pulse-binding/src/stream.rs

@@ -1752,7 +1752,7 @@ impl Stream {
         // as_ptr() giving dangling pointers!
         let mut c_keys: Vec<CString> = Vec::with_capacity(keys.len());
         for key in keys {
-            c_keys.push(CString::new(key.clone()).unwrap());
+            c_keys.push(CString::new(*key).unwrap());
         }
 
         // Capture array of pointers to the above CString values