Skip to content

[Suggestion] RFC 5256 - SORT command #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
soywod opened this issue Jan 15, 2021 · 8 comments
Closed

[Suggestion] RFC 5256 - SORT command #178

soywod opened this issue Jan 15, 2021 · 8 comments
Milestone

Comments

@soywod
Copy link
Contributor

soywod commented Jan 15, 2021

It could be nice to implement the SORT command from the RFC 5256. Plus it's close to the SEARCH command, so it should not be that difficult to integrate.

@jonhoo
Copy link
Owner

jonhoo commented Jan 23, 2021

I agree, that seems reasonable! Would be happy to take a look at a PR.

@soywod
Copy link
Contributor Author

soywod commented Mar 10, 2021

I'm building a CLI email client and I would love this feature to sort messages by date. I will try to implement it ASAP and propose a PR.

@soywod
Copy link
Contributor Author

soywod commented Mar 11, 2021

It seems that the lib imap-proto does not have the parser for the SORT command, I opened an issue there.

[EDIT] I proposed a PR and it has been merged 🎉 so now I will prepare the PR for your repo.

@jonhoo
Copy link
Owner

jonhoo commented Apr 20, 2021

Fixed by #180.

@jonhoo jonhoo closed this as completed Apr 20, 2021
@jonhoo jonhoo added this to the 3.0.0 milestone Apr 20, 2021
@soywod
Copy link
Contributor Author

soywod commented May 9, 2021

@jonhoo I integrated the v3.0.0-alpha.3 in my tool (mostly to use the sort cmd), and I saw some breaking changes. I noticed that the changelog is not up-to-date, would you like me to update it with the changes I noticed or you prefer to wait for the release v3.0.0 to list all the breaking changes?

@jonhoo
Copy link
Owner

jonhoo commented May 9, 2021

That'd be great, thank you! There should be an [unreleased] header that you can add them under.

@soywod
Copy link
Contributor Author

soywod commented May 9, 2021

Yes, I recognized the format, I also use the same 😉

@soywod
Copy link
Contributor Author

soywod commented May 9, 2021

#199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants