diff --git a/microesc/urbansound8k.py b/microesc/urbansound8k.py index 1da67b7..240a8db 100644 --- a/microesc/urbansound8k.py +++ b/microesc/urbansound8k.py @@ -69,7 +69,26 @@ def download_progress(count, blocksize, totalsize): print('Extracting...', archive_path) # Note: .zip file is kept around with tarfile.open(archive_path, "r:gz") as archive: - archive.extractall(workdir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(archive, workdir) return dir_path