Skip to content

Commit 664fdc3

Browse files
authored
Merge pull request github#11815 from aibaars/too-many-fields
Ruby: use record_parse_error_for_node to report extractor error
2 parents 5157d4d + 799e0c1 commit 664fdc3

File tree

1 file changed

+13
-4
lines changed

1 file changed

+13
-4
lines changed

ruby/extractor/src/extractor.rs

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -500,13 +500,22 @@ impl<'a> Visitor<'a> {
500500
} => {
501501
for (index, child_value) in child_values.iter().enumerate() {
502502
if !*has_index && index > 0 {
503-
error!(
504-
"{}:{}: too many values for field: {}::{}",
505-
&self.path,
506-
node.start_position().row + 1,
503+
let error_message = format!(
504+
"too many values for field: {}::{}",
507505
node.kind(),
508506
table_name,
509507
);
508+
let full_error_message = format!(
509+
"{}:{}: {}",
510+
&self.path,
511+
node.start_position().row + 1,
512+
error_message
513+
);
514+
self.record_parse_error_for_node(
515+
error_message,
516+
full_error_message,
517+
*node,
518+
);
510519
break;
511520
}
512521
let mut args = vec![trap::Arg::Label(parent_id)];

0 commit comments

Comments
 (0)