Skip to content

Commit 4308d3e

Browse files
authored
Fix typing for select and option react components (#24)
1 parent ffd8f31 commit 4308d3e

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

packages/react-components/src/option/index.tsx

+2
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ const { wrap } = provideReactWrapper(React, provideJupyterDesignSystem());
1212

1313
export const Option: React.DetailedHTMLFactory<
1414
React.HTMLAttributes<HTMLElement> & {
15+
checked?: boolean;
16+
defaultSelected?: boolean;
1517
disabled?: boolean;
1618
selected?: boolean;
1719
value?: string;

packages/react-components/src/select/index.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ export const Select: React.DetailedHTMLFactory<
1616
minimal?: boolean;
1717
open?: boolean;
1818
position?: 'above' | 'below';
19+
value?: string;
1920
},
2021
HTMLElement
2122
> = wrap(jpSelect(), {

0 commit comments

Comments
 (0)