Skip to content

Commit b75603a

Browse files
authored
Merge pull request #68 from myfreeweb/master
Various little features for new Custom Elements wrapper & bug fixes
2 parents 5a4d0a6 + 9624e60 commit b75603a

File tree

6 files changed

+28
-15
lines changed

6 files changed

+28
-15
lines changed

build/codeflask.min.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

build/codeflask.module.js

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+2
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,10 @@
33
"version": "1.0.5",
44
"description": "A micro code-editor for awesome web pages",
55
"main": "build/codeflask.min.js",
6+
"module": "build/codeflask.module.js",
67
"files": [
78
"build/codeflask.min.js",
9+
"build/codeflask.module.js",
810
"README.md",
911
"LICENSE"
1012
],

rollup.config.js

+14-6
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,20 @@ const production = !process.env.ROLLUP_WATCH;
77

88
export default {
99
input: 'src/codeflask.js',
10-
output: {
11-
sourcemap: false,
12-
format: 'umd',
13-
name: 'CodeFlask',
14-
file: 'build/codeflask.min.js'
15-
},
10+
output: [
11+
{
12+
sourcemap: false,
13+
format: 'umd',
14+
name: 'CodeFlask',
15+
file: 'build/codeflask.min.js'
16+
},
17+
{
18+
sourcemap: false,
19+
format: 'es',
20+
name: 'CodeFlask',
21+
file: 'build/codeflask.module.js'
22+
},
23+
],
1624
plugins: [
1725
// If you have external dependencies installed from
1826
// npm, you'll most likely need these plugins. In

src/codeflask.js

+6-5
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export default class CodeFlask {
3939
}
4040

4141
startEditor() {
42-
const isCSSInjected = inject_css(editor_css);
42+
const isCSSInjected = inject_css(editor_css, null, this.opts.styleParent);
4343

4444
if (!isCSSInjected) {
4545
throw Error('Failed to inject CodeFlask CSS.');
@@ -99,7 +99,7 @@ export default class CodeFlask {
9999
this.opts.tabSize = this.opts.tabSize || 2;
100100
this.opts.enableAutocorrect = this.opts.enableAutocorrect || false;
101101
this.opts.lineNumbers = this.opts.lineNumbers || false;
102-
this.opts.defaultTheme = this.opts.defaultTheme || true;
102+
this.opts.defaultTheme = this.opts.defaultTheme !== false;
103103

104104
if (this.opts.rtl === true) {
105105
this.elTextarea.setAttribute('dir', 'rtl');
@@ -119,7 +119,7 @@ export default class CodeFlask {
119119
}
120120

121121
if (this.opts.defaultTheme) {
122-
inject_css(default_css_theme, 'theme-default');
122+
inject_css(default_css_theme, 'theme-default', this.opts.styleParent);
123123
}
124124
}
125125

@@ -153,7 +153,9 @@ export default class CodeFlask {
153153

154154
this.elTextarea.addEventListener('scroll', (e) => {
155155
this.elPre.style.transform = `translate3d(-${e.target.scrollLeft}px, -${e.target.scrollTop}px, 0)`;
156-
this.elLineNumbers.style.transform = `translate3d(0, -${e.target.scrollTop}px, 0)`;
156+
if (this.elLineNumbers) {
157+
this.elLineNumbers.style.transform = `translate3d(0, -${e.target.scrollTop}px, 0)`;
158+
}
157159
});
158160
}
159161

@@ -202,7 +204,6 @@ export default class CodeFlask {
202204

203205
setLineNumber() {
204206
this.lineNumber = this.code.split('\n').length;
205-
console.log(this.lineNumber);
206207

207208
if (this.opts.lineNumbers) {
208209
this.updateLineNumbersCount();

src/styles/injector.js

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1-
export function inject_css(css, styleName) {
1+
export function inject_css(css, styleName, parent) {
22
const CSS_ID = styleName || 'codeflask-style';
3-
3+
const PARENT = parent || document.head;
4+
45
if (!css) {
56
return false;
67
}
@@ -13,7 +14,7 @@ export function inject_css(css, styleName) {
1314

1415
style.innerHTML = css;
1516
style.id = CSS_ID;
16-
document.head.appendChild(style);
17+
PARENT.appendChild(style);
1718

1819
return true;
1920
}

0 commit comments

Comments
 (0)