Skip to content

Commit 03e5c7c

Browse files
committed
Update bitcode TODO
As of Xcode 14 Bitcode is deprecated but Apple still accepts apps built with bitcode if you're still using Xcode 13. Once Apple stops allowing you to upload apps built with Xcode 13 this argument should be removed. rust-lang#768
1 parent 203a57f commit 03e5c7c

File tree

1 file changed

+1
-11
lines changed

1 file changed

+1
-11
lines changed

src/lib.rs

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2279,18 +2279,8 @@ impl Build {
22792279

22802280
cmd.args.push("-isysroot".into());
22812281
cmd.args.push(sdk_path);
2282+
// TODO: Remove this once Apple stops accepting apps built with Xcode 13
22822283
cmd.args.push("-fembed-bitcode".into());
2283-
/*
2284-
* TODO we probably ultimately want the -fembed-bitcode-marker flag
2285-
* but can't have it now because of an issue in LLVM:
2286-
* https://github.com/rust-lang/cc-rs/issues/301
2287-
* https://github.com/rust-lang/rust/pull/48896#comment-372192660
2288-
*/
2289-
/*
2290-
if self.get_opt_level()? == "0" {
2291-
cmd.args.push("-fembed-bitcode-marker".into());
2292-
}
2293-
*/
22942284

22952285
Ok(())
22962286
}

0 commit comments

Comments
 (0)