Skip to content

+kselftest need to run baseline jobs #1490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nuclearcat opened this issue Nov 3, 2022 · 3 comments
Closed

+kselftest need to run baseline jobs #1490

nuclearcat opened this issue Nov 3, 2022 · 3 comments
Assignees

Comments

@nuclearcat
Copy link
Member

As mentioned in #1236 (comment) :

 it would really help if we had baseline jobs running for the kselftest kernels but unfortunately we don't seem to.

We need to add baseline jobs for kselftest kernels as it seems some of them just fail to boot.

@mgalka what's your opinion on that?

@nuclearcat
Copy link
Member Author

@gctucker do you think it is feasible to test kselftest kernels on baseline too?
It will add load to labs, but seems it might be useful, as some kselftest kernels was not bootable.
Right now we have them excluded from baseline tests:

    filters:
      - blocklist: *kselftest_defconfig_filter

@nuclearcat nuclearcat self-assigned this Dec 29, 2022
@gctucker
Copy link
Contributor

gctucker commented Jan 3, 2023

Yes, and I think baseline-nfs would make more sense with kselftest. Maybe both would be useful actually. I'm just not entirely sure any more why this filter was created, I see in the git history that it was inherited from the original boot tests. Most likely, kselftest kernels were only built and not used at all at the time so it's worth trying to enable that now.

Note: Ideally, I think baseline on kselftest kernels should only be run in labs that also have kselftest enabled. But that's more something for the new pipeline syntax (which doesn't exist yet) where we could define dependencies between tests. So kselftest tests would only run if the baseline test with the kselftest kernel passed. It should be useful preparation work to just enable baseline on kselftest everywhere for now.

@nuclearcat
Copy link
Member Author

Fixed by #1606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants