Skip to content

Commit a014d73

Browse files
Jeny SadadiaJenySadadia
Jeny Sadadia
authored andcommitted
src/send_kcidb: add a check before sending data
Check if parsed data is available before sending revision data to KCIDB. Signed-off-by: Jeny Sadadia <[email protected]>
1 parent 29898f2 commit a014d73

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

src/send_kcidb.py

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -57,14 +57,16 @@ def _remove_none_fields(self, data):
5757

5858
def _send_revision(self, client, revision):
5959
revision = self._remove_none_fields(revision)
60-
self.log.debug(f"DEBUG: sending revision: {revision}")
61-
if kcidb.io.SCHEMA.is_valid(revision):
62-
return client.submit(revision)
63-
self.log.error("Aborting, invalid data")
64-
try:
65-
kcidb.io.SCHEMA.validate(revision)
66-
except Exception as exc:
67-
self.log.error(f"Validation error: {str(exc)}")
60+
if any(value for key, value in revision.items() if key != 'version'):
61+
self.log.debug(f"DEBUG: sending revision: {revision}")
62+
if kcidb.io.SCHEMA.is_valid(revision):
63+
client.submit(revision)
64+
else:
65+
self.log.error("Aborting, invalid data")
66+
try:
67+
kcidb.io.SCHEMA.validate(revision)
68+
except Exception as exc:
69+
self.log.error(f"Validation error: {str(exc)}")
6870

6971
@staticmethod
7072
def _set_timezone(created_timestamp):

0 commit comments

Comments
 (0)