Skip to content

Commit fbe1bd1

Browse files
committed
(send_kcidb.py) Fix logspec trigger by status
Due deprecation of field 'valid' in kcidb schema, we lost trigger condition when 'valid' == false was triggering logspec. We can trigger same as on tests, by status == FAIL, which was equivalent to `valid` retrieved by status map. Signed-off-by: Denys Fedoryshchenko <[email protected]>
1 parent e2af4b5 commit fbe1bd1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/send_kcidb.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -833,7 +833,7 @@ def _handle_failures(self, parsed_data, batch, context):
833833
"""Handle failed builds and tests by generating issues/incidents"""
834834
# Handle failed builds
835835
for parsed_node in parsed_data['build_node']:
836-
if parsed_node.get('valid') is False and parsed_node.get('log_url'):
836+
if parsed_node.get("status") == "FAIL" and parsed_node.get('log_url'):
837837
parsed_fail = self._parse_fail_node(parsed_node, context, 'build')
838838
self._add_to_batch(batch, parsed_fail)
839839

0 commit comments

Comments
 (0)