Merge pull request #968 from kiwix/962-regression-opening-app-with-zim-doesnt-open-zim

Fix opening app with ZIM doesn't open ZIM

Author: kelson42

App/App_macOS.swift

@@ -194,6 +194,7 @@ struct RootView: View {
             browser.load(url: url)
         }
         .onReceive(tabCloses) { publisher in
+            // closing one window either by CMD+W || red(X) close button
             guard windowTracker.current == publisher.object as? NSWindow else {
                 // when exiting full screen video, we get the same notification
                 // but that's not comming from our window
@@ -210,8 +211,8 @@ struct RootView: View {
             }
         }
         .onReceive(appTerminates) { _ in
+            // CMD+Q -> Quit Kiwix, this also closes the last window
             navigation.isTerminating = true
-            browser.persistAllTabIdsFromWindows()
         }.task {
             switch AppType.current {
             case .kiwix:

CHANGELOG.md

@@ -1,5 +1,6 @@
 ## 3.5.2
-
+- FIX:
+  - Opening ZIM file from macOS Finder (@BPerlakiH #968)
 
 ## 3.5.1
 - FIX:

ViewModel/BrowserViewModel.swift

@@ -597,13 +597,6 @@ final class BrowserViewModel: NSObject, ObservableObject,
     }
 
     // PERSISTENCE:
-    func persistAllTabIdsFromWindows() {
-        let urls = NSApplication.shared.windows.compactMap { window in
-            window.accessibilityURL()
-        }
-        UserDefaults.standard[.windowURLs] = urls
-    }
-
     private func storeTabIDInCurrentWindow() {
         guard let tabID,
               let windowNumber,