部分重构

Author: muyinchen

chapter14/Spring Demo/rx-react/src/test/java/com/dockerx/rxreact/repository/GitHbubReposTest.java

@@ -65,7 +65,7 @@ public void getRepos() {
     @Test
     public void getCommitsInWeek() {
         String aWeekAgo = ZonedDateTime.now(ZoneOffset.UTC).minusWeeks(1).minusDays(1)
-                                       .format(DateTimeFormatter.ofPattern("yyyy-MM-dd'T'00:00:00'Z'"));;
+                                       .format(DateTimeFormatter.ofPattern("yyyy-MM-dd'T'00:00:00'Z'"));
         MockRestServiceServer mockServer = MockRestServiceServer.bindTo(restTemplate).build();
         mockServer.expect(requestTo(String.format(GitHbubRepos.COMMITS, user, repo, aWeekAgo)))
                   .andRespond(withSuccess( /*此处请自行添加结果测试，或者找自己的仓库设置*/

chapter14/Spring Demo/rx-react/src/test/java/com/dockerx/rxreact/services/GitHubServiceImplTest.java

@@ -2,6 +2,7 @@
 
 import com.dockerx.rxreact.domain.*;
 import com.dockerx.rxreact.repository.GitHbubRepos;
+import io.reactivex.Flowable;
 import io.reactivex.subscribers.TestSubscriber;
 import org.junit.Before;
 import org.junit.Test;
@@ -33,11 +34,13 @@ public class GitHubServiceImplTest {
     @Before
     public void setup() {
         initMocks(this);
-        gitHubService=new GitHubServiceImpl(gitHbubRepos);
-        when(gitHbubRepos.getRepos(anyString())).thenAnswer(m->getReposForTest());
+        gitHubService = new GitHubServiceImpl(gitHbubRepos);
+        when(gitHbubRepos.getRepos(anyString())).thenAnswer(m -> getReposForTest());
 
         when(gitHbubRepos.getCommitsInWeek(anyString(), anyString())).thenAnswer(m -> getCommitsInWeekForTest());
-        when(gitHbubRepos.getSingleCommit(anyString(), anyString(), anyString())).thenAnswer(m -> getSingleCommitForTest());
+        when(gitHbubRepos.getSingleCommit(anyString(),
+                anyString(),
+                anyString())).thenAnswer(m -> getSingleCommitForTest());
         when(gitHbubRepos.getSingleCommitByUrl(anyString())).thenAnswer(m -> getSingleCommitForTest());
     }
 
@@ -52,6 +55,7 @@ private List<Repository> getReposForTest() {
                 new Repository("repo3", LocalDateTime.now().minusDays(3))
         );
     }
+
     @Test
     public void getRepos() {
         TestSubscriber<String> testSubscriber = new TestSubscriber<>();
@@ -63,7 +67,7 @@ public void getRepos() {
         testSubscriber.assertNoErrors();
         assertThat(testSubscriber.values())
                 .as("getRepos returns all user code repository ")
-                .containsExactly("repo1  ","repo2  ", "repo3  ");
+                .containsExactly("repo1  ", "repo2  ", "repo3  ");
     }
 
     @Test
@@ -94,7 +98,6 @@ public void getCommitsInWeek() {
     }
 
 
-
     @Test
     public void getCommittedFilesByUser() {
         TestSubscriber<CommittedFile> testSubscriber = new TestSubscriber<>();
@@ -117,13 +120,23 @@ private List<Commit> getCommitsInWeekForTest() {
         return Arrays.asList(
                 Commit.builder()
                       .sha("sha1")
-                      .committer(new Committer("test-user","https://github.com/muyinchen","https://api.github.com/users/muyinchen/orgs"))
-                      .author(new Author("url2","https://github.com/muyinchen",true,"https://api.github.com/users/muyinchen/orgs"))
+                      .committer(new Committer("test-user",
+                              "https://github.com/muyinchen",
+                              "https://api.github.com/users/muyinchen/orgs"))
+                      .author(new Author("url2",
+                              "https://github.com/muyinchen",
+                              true,
+                              "https://api.github.com/users/muyinchen/orgs"))
                       .build(),
                 Commit.builder()
                       .sha("sha2")
-                      .committer(new Committer("no-test-user","https://github.com/muyinchen/no-test-user","https://api.github.com/users/muyinchen/orgs/no-test-user"))
-                      .author(new Author("url2","https://github.com/muyinchen/no-test-user",true,"https://api.github.com/users/muyinchen/orgs/no-test-user"))
+                      .committer(new Committer("no-test-user",
+                              "https://github.com/muyinchen/no-test-user",
+                              "https://api.github.com/users/muyinchen/orgs/no-test-user"))
+                      .author(new Author("url2",
+                              "https://github.com/muyinchen/no-test-user",
+                              true,
+                              "https://api.github.com/users/muyinchen/orgs/no-test-user"))
                       .build()
         );
     }
@@ -140,4 +153,20 @@ private SingleCommit getSingleCommitForTest() {
                 )
         );
     }
+
+    @Test
+    public void testTestSubscriber() {
+
+        TestSubscriber<String> testSubscriber = new TestSubscriber<>();
+        //In order to emit "1", "2", "3"
+        Flowable.just("1", "2", "3").subscribe(testSubscriber);
+        //Assert whether values are equal
+        testSubscriber.assertValues("1", "2", "3");
+        //Assert value does not exist
+        testSubscriber.assertNever("4");
+        //Is the number of asserted values equal?
+        testSubscriber.assertValueCount(3);
+        //Assertion terminated
+        testSubscriber.assertTerminated();
+    }
 }