Skip to content

Allow users to set labels and annotations on vSphereCluster, Machine and VirtualMachine #3374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fabriziopandini opened this issue Mar 5, 2025 · 1 comment
Open

Allow users to set labels and annotations on vSphereCluster, Machine and VirtualMachine #3374

fabriziopandini opened this issue Mar 5, 2025 · 1 comment
Labels
area/supervisor Issues or PRs related to the supervisor mode kind/feature Categorizes issue or PR as related to a new feature.

Comments

@fabriziopandini
Copy link
Member

/kind feature

Describe the solution you'd like
Currently CAPV uses createOrPatch to reconcile its objects, but this is not friendly with other clients setting labels and annotations on those objects.

We should fix this
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 5, 2025
@sbueringer
Copy link
Member

Let's consider if for some of these cases patchHelper would be the better choice, but this could also be a follow-up as fixing the label & annotation thing is a quick win

@sbueringer sbueringer added the area/supervisor Issues or PRs related to the supervisor mode label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/supervisor Issues or PRs related to the supervisor mode kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sbueringer @fabriziopandini @k8s-ci-robot