tmp - fixing linter

Signed-off-by: Yoni Bettan <[email protected]>

Author: ybettan

internal/webhook/moduleconvertor.go

@@ -33,6 +33,7 @@ type ModuleDefaulter struct {
 	logger logr.Logger
 }
 
+// FIXME: add the new webhook to both manager & manager-hub
 func NewModuleDefaulter(logger logr.Logger) *ModuleDefaulter {
 	return &ModuleDefaulter{logger: logger}
 }
@@ -51,10 +52,9 @@ func (md *ModuleDefaulter) SetupWebhookWithManager(mgr ctrl.Manager) error {
 // Default implements webhook.Default so a webhook will be registered for the type
 func (md *ModuleDefaulter) Default(ctx context.Context, obj runtime.Object) error {
 
-	mod, ok := obj.(kmmv1beta1.Module) //FIXME: does it have to be a pointer?
-	//mod, ok := obj.(*kmmv1beta1.Module)
+	mod, ok := obj.(*kmmv1beta1.Module)
 	if !ok {
-		fmt.Errorf("bad type for the object; expected %T, got %T", mod, obj)
+		return fmt.Errorf("bad type for the object; expected %T, got %T", mod, obj)
 	}
 
 	md.logger.Info("Mutating Module creation", "name", mod.Name, "namespace", mod.Namespace)
@@ -70,9 +70,9 @@ func setDefaultContainerImageTagIfNeeded(mod *kmmv1beta1.Module) {
 	setDefaultTagIfNeeded(&mod.Spec.ModuleLoader.Container.ContainerImage)
 }
 
-func setDefaultKernelMappingTags(mod *kmmv1beta1.Module) {
+func setDefaultKernelMappingTagsIfNeeded(mod *kmmv1beta1.Module) {
 
-	for i, _ := range mod.Spec.ModuleLoader.Container.KernelMappings {
+	for i := range mod.Spec.ModuleLoader.Container.KernelMappings {
 		setDefaultTagIfNeeded(&mod.Spec.ModuleLoader.Container.KernelMappings[i].ContainerImage)
 	}
 }