Skip to content

Lua: Fix ExternalName services without endpoints. #13154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Lua: Fix ExternalName services without endpoints. #13154

wants to merge 3 commits into from

Conversation

neerfri
Copy link
Contributor

@neerfri neerfri commented Apr 3, 2025 •
edited
Loading

Due to kubernetes/kubernetes#114814 kubernetes no longer creates endpoints for services of type ExternalService. This in turn causes an exception when using an ingress that is backed by such service.

Due to #12952 , which I authored, this causes an exception reported in several recent issues that were opened after the new functionality was released.

I'm still puzzled why the e2e tests in https://github.com/kubernetes/ingress-nginx/blob/main/test/e2e/servicebackend/service_externalname.go did not catch those problems on effected versions of Kubernetes.

This is also related to:

What this PR does / why we need it:

We need this to stabilize the behavior of Ingress backend by a service with type ExternalName across different kubernetes versions and going forward.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

fixes #13081

How Has This Been Tested?

Adding tests to the Lua part of the code that was effected covering previously untested behavior and the specific exception from issue #13081

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 3, 2025
@k8s-ci-robot k8s-ci-robot requested review from Gacko and strongjz April 3, 2025 08:22
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: neerfri
Once this PR has been reviewed and has the lgtm label, please assign gacko for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/lua Issues or PRs related to lua code label Apr 3, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @neerfri. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 3, 2025
@netlify Netlify
Copy link

netlify bot commented Apr 3, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit 07260bf
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/67eed66d44210c0008088bb6

@neerfri neerfri mentioned this pull request Apr 3, 2025
Open
@Gacko
Copy link
Member

Gacko commented Apr 12, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 12, 2025
@Gacko
Copy link
Member

Gacko commented Apr 12, 2025

/triage accepted
/kind bug
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Apr 12, 2025
@Gacko Gacko changed the title Fix exception using ExternalName with empty endpoint list Lua: Fix ExternalName services without endpoints. Apr 12, 2025
@k8s-ci-robot
Copy link
Contributor

@neerfri: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-ingress-nginx-lua-test 07260bf link true /test pre-ingress-nginx-lua-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Gacko Gacko changed the title Lua: Fix ExternalName services without endpoints. Lua: Fix ExternalName services without endpoints. Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gacko Gacko Awaiting requested review from Gacko

@strongjz strongjz Awaiting requested review from strongjz

Assignees
No one assigned
Labels
area/lua Issues or PRs related to lua code cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression when using ExternalName services
3 participants
@neerfri @k8s-ci-robot @Gacko