Delete System.Data.SqlClient package (dotnet#2275)

* Delete System.Data.SqlClient package

* Delete unnecessary SqlClient references

* Unify System.Data.SqlClient package reference

* Add System.Data facade test

* Add System.Data.SqlClient references
- Add System.Data.SqlClient package references for tests that need it
- Use System.Data.SqlClient reference assembly to build the System.Data shim
- Disable ILLinker for the shims since it does not work well with incremental builds and it is not necessary anyway

* Disable tests on Mono

Fixes https://github.com/dotnet/corefx/issues/40846

Author: jkotas

.config/CredScanSuppressions.json

@@ -17,12 +17,6 @@
       "/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/EC/ECKeyFileTests.cs",
       "/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs",
       "/src/libraries/System.Data.Common/tests/System/Data/Common/DbConnectionStringBuilderTest.cs",
-      "/src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/TdsEnums.cs",
-      "/src/libraries/System.Data.SqlClient/tests/FunctionalTests/DiagnosticTest.cs",
-      "/src/libraries/System.Data.SqlClient/tests/FunctionalTests/ExceptionTest.cs",
-      "/src/libraries/System.Data.SqlClient/tests/FunctionalTests/SqlConnectionBasicTests.cs",
-      "/src/libraries/System.Data.SqlClient/tests/Tools/TDS/TDS.Servers/TDSServerArguments.cs",
-      "/src/libraries/System.Data.SqlClient/tests/Tools/TDS/TDS.Servers/TdsServerCertificate.pfx",
       "/src/libraries/System.Diagnostics.Process/tests/ProcessStartInfoTests.cs",
       "/src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/constants.cs",
       "/src/libraries/System.DirectoryServices.AccountManagement/tests/PrincipalTest.cs",

eng/Versions.props

@@ -110,8 +110,8 @@
     <RefOnlyMicrosoftBuildUtilitiesCoreVersion>$(RefOnlyMicrosoftBuildVersion)</RefOnlyMicrosoftBuildUtilitiesCoreVersion>
     <RefOnlyNugetProjectModelVersion>4.9.4</RefOnlyNugetProjectModelVersion>
     <RefOnlyNugetPackagingVersion>4.9.4</RefOnlyNugetPackagingVersion>
-    <!-- sni -->
-    <RuntimeWinX64RuntimeNativeSystemDataSqlClientSniVersion>4.4.0</RuntimeWinX64RuntimeNativeSystemDataSqlClientSniVersion>
+    <!-- System.Data.SqlClient -->
+    <SystemDataSqlClientVersion>4.8.0</SystemDataSqlClientVersion>
     <!-- Testing -->
     <MicrosoftNETTestSdkVersion>16.5.0</MicrosoftNETTestSdkVersion>
     <XUnitVersion>2.4.1</XUnitVersion>

src/coreclr/tests/scripts/run-corefx-tests.bat

@@ -27,7 +27,7 @@ echo control, but is easy to implement. This file should be a list of assembly n
 echo without filename extension, one per line, e.g.:
 echo.
 echo     System.Console.Tests
-echo     System.Data.SqlClient.Tests
+echo     System.Data.Common.Tests
 echo     System.Diagnostics.Process.Tests
 echo.
 echo The ^<exclusion rsp file^> is in the form expected by xunit.console.dll as a response file.

src/libraries/Native/pkg/Directory.Build.props

@@ -76,6 +76,7 @@
     <Compile Include="System\Data\DeletedRowInaccessibleExceptionTest.cs" />
     <Compile Include="System\Data\DuplicateNameExceptionTest.cs" />
     <Compile Include="System\Data\EvaluateExceptionTest.cs" />
+    <Compile Include="System\Data\FacadeTest.cs" />
     <Compile Include="System\Data\ForeignKeyConstraintTest.cs" />
     <Compile Include="System\Data\ForeignKeyConstraintTest2.cs" />
     <Compile Include="System\Data\InRowChangingEventExceptionTest.cs" />
@@ -119,4 +120,7 @@
       <Link>Common\System\Runtime\Serialization\Formatters\BinaryFormatterHelpers.cs</Link>
     </Compile>
   </ItemGroup>
+  <ItemGroup>
+    <PackageReference Include="System.Data.SqlClient" Version="$(SystemDataSqlClientVersion)" />
+  </ItemGroup>
 </Project>

src/libraries/Native/pkg/Directory.Build.targets

@@ -0,0 +1,19 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// See the LICENSE file in the project root for more information.
+
+using Xunit;
+
+namespace System.Data.Tests
+{
+    public class FacadeTest
+    {
+        [Theory]
+        [InlineData("Microsoft.SqlServer.Server.SqlMetaData")] // Type from System.Data.SqlClient
+        [InlineData("System.Data.SqlTypes.SqlBytes")] // Type from System.Data.Common
+        public void TestSystemData(string typeName)
+        {
+            // Verify that the type can be loaded via .NET Framework compat facade
+            Type.GetType(typeName + ", System.Data", throwOnError: true);
+        }
+    }
+}

src/libraries/Native/pkg/_.pdb

@@ -6,7 +6,6 @@
 using System.ComponentModel;
 using System.Diagnostics;
 using System.Globalization;
-using System.Data.SqlClient;
 
 namespace System.Data.Common
 {

src/libraries/Native/pkg/runtime.native.System.Data.SqlClient.sni/runtime.native.System.Data.SqlClient.sni.pkgproj

@@ -102,7 +102,6 @@
   <ItemGroup Condition="'$(TargetsNetFx)' != 'true'">
     <Reference Include="Microsoft.Win32.Registry" />
     <Reference Include="System.Memory" />
-    <Reference Include="System.Data.SqlClient" />
     <Reference Include="System.Configuration.ConfigurationManager" />
     <Reference Include="System.Diagnostics.PerformanceCounter" />
     <Reference Include="System.Security.Principal.Windows" />