Registry cache implementation: add a property to the Runtime CR that enables the cache #886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
m00g3n
reviewed
May 14, 2025
| ) | ||
|
|
||
| func getRegistryCache(ctx context.Context, s *systemState, m *fsm) ([]v1beta1.RegistryCache, error) { | ||
| getSecretFunc := func() (v1.Secret, error) { |
There was a problem hiding this comment.
Can we either
- modify
getRegistryCachefunction signature and passgetSecretFuncfunction as argument or - limit arguments just to
Client,LabelsandNamespace
There was a problem hiding this comment.
I just got rid of getSecretFunc as it is not needed for now (and probably won't be).
m00g3n
reviewed
May 14, 2025
| kubeconfigSecretKey = "config" | ||
| ) | ||
|
|
||
| // TODO: Use this function in the Runtime Controller's FSM |
There was a problem hiding this comment.
FSM states for OIDC, and RBAC use a function that is defined in the fsm package. In the next steps I will refactor this to use the function from the github.com/kyma-project/infrastructure-manager/pkg/gardener package.
Merging this branch changes the coverage (2 decrease, 1 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
m00g3n
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
spec.imageRegistryCache.enabledproperty addedspec.imageRegistryCache.enabledis true registry config extension is configured based on the settings from CustomConfig CRRelated issue(s)
#635