remove key file name validation

Author: werberson

manager/manager_test.go

@@ -14,7 +14,7 @@ const basePath = "./data"
 
 func TestMain(m *testing.M) {
 	exitCode := m.Run()
-	os.Remove(basePath)
+	_ = os.Remove(basePath)
 	os.Exit(exitCode)
 }
 
@@ -56,7 +56,7 @@ func TestAddDNSRecordAndGetAndList(t *testing.T) {
 	}
 
 	if len(records) != 1 {
-		t.Errorf("Expecting the list of records to have exactly one entry. Got %v", len(records))
+		t.Fatalf("Expecting the list of records to have exactly one entry. Got %v", len(records))
 	}
 
 	if records[0].Name != rs[0].Name || records[0].Value != rs[0].Value || records[0].Type != rs[0].Type {
@@ -190,15 +190,15 @@ type MockDNSUpdater struct {
 	RemovalCount uint64
 }
 
-func (mnsu *MockDNSUpdater) AddRR(record hookTypes.DNSRecord, ttl time.Duration) error {
+func (mnsu *MockDNSUpdater) AddRR(_ hookTypes.DNSRecord, _ time.Duration) error {
 	return mnsu.Error
 }
 
-func (mnsu *MockDNSUpdater) RemoveRR(name, recordType string) error {
+func (mnsu *MockDNSUpdater) RemoveRR(_, _ string) error {
 	atomic.AddUint64(&mnsu.RemovalCount, 1)
 	return mnsu.Error
 }
 
-func (mnsu *MockDNSUpdater) UpdateRR(record hookTypes.DNSRecord, ttl time.Duration) error {
+func (mnsu *MockDNSUpdater) UpdateRR(_ hookTypes.DNSRecord, _ time.Duration) error {
 	return mnsu.Error
 }

nsupdate/misc_test.go

@@ -47,7 +47,7 @@ func TestNSUpdate_buildDeleteCommand(t *testing.T) {
 				Builder: tt.fields.Builder,
 			}
 			if got := nsu.buildDeleteCommand(tt.args.recordName, tt.args.recordType); got != tt.want {
-				t.Errorf("NSUpdate.buildDeleteCommand() = %v, want %v", got, tt.want)
+				t.Errorf("%s: NSUpdate.buildDeleteCommand() = %v, want %v", tt.name, got, tt.want)
 			}
 		})
 	}
@@ -94,7 +94,7 @@ func TestNSUpdate_buildAddCommand(t *testing.T) {
 				Builder: tt.fields.Builder,
 			}
 			if got := nsu.buildAddCommand(tt.args.recordName, tt.args.recordType, tt.args.value, tt.args.ttl); got != tt.want {
-				t.Errorf("NSUpdate.buildAddCommand() = %v, want %v", got, tt.want)
+				t.Errorf("%s: NSUpdate.buildAddCommand() = %v, want %v", tt.name, got, tt.want)
 			}
 		})
 	}
@@ -149,12 +149,12 @@ func TestCheck(t *testing.T) {
 				t.Errorf("It was expected success=false but returned true")
 			}
 			if len(errs) != len(test.expected.errs) {
-				t.Errorf("The error array length must be %d but got %d", len(test.expected.errs), len(errs))
+				t.Errorf("%s: The error array length must be %d but got %d", test.name, len(test.expected.errs), len(errs))
 				t.FailNow()
 			}
 			for i, err := range test.expected.errs {
 				if errs[i] != err {
-					t.Errorf("Expected message was %s but got %s", err, errs[i])
+					t.Errorf("%s: Expected message was %s but got %s", test.name, err, errs[i])
 				}
 			}
 		})
@@ -271,7 +271,7 @@ func TestNSUpdate_getKeyFilePath(t *testing.T) {
 				Builder: *tt.fields.Builder,
 			}
 			if got := nsu.getKeyFilePath(); got != tt.want {
-				t.Errorf("NSUpdate.getKeyFilePath() = %v, want %v", got, tt.want)
+				t.Errorf("%s: NSUpdate.getKeyFilePath() = %v, want %v", tt.name, got, tt.want)
 			}
 		})
 	}