fix(COD-4672): Default to Installed if apiInfo is nil (#1687)

Author: jeffreynglw

lwcomponent/catalog_test.go

@@ -87,7 +87,7 @@ func TestCatalogNewCatalog(t *testing.T) {
 		assert.Nil(t, err)
 	})
 
-	t.Run("installed", func(t *testing.T) {
+	t.Run("installed when ApiInfo is nil", func(t *testing.T) {
 		fakeServer := lacework.MockServer()
 		defer fakeServer.Close()
 
@@ -394,9 +394,9 @@ func TestCatalogGetComponent(t *testing.T) {
 		assert.Equal(t, version, ver.String())
 	})
 
-	t.Run("installed deprecated", func(t *testing.T) {
+	t.Run("installed when ApiInfo is nil", func(t *testing.T) {
 		var (
-			name    = "installed deprecated"
+			name    = "installed"
 			version = "1.1.0"
 		)
 
@@ -411,7 +411,7 @@ func TestCatalogGetComponent(t *testing.T) {
 		component, err := catalog.GetComponent(name)
 		assert.NotNil(t, component)
 		assert.Nil(t, err)
-		assert.Equal(t, lwcomponent.InstalledDeprecated, component.Status)
+		assert.Equal(t, lwcomponent.Installed, component.Status)
 
 		ver := component.InstalledVersion()
 		assert.Equal(t, version, ver.String())

lwcomponent/cdk_component.go

@@ -210,7 +210,7 @@ func status(apiInfo *ApiInfo, hostInfo *HostInfo) Status {
 				return Installed
 			}
 		} else {
-			return InstalledDeprecated
+			return Installed
 		}
 	}
 

lwcomponent/cdk_component_test.go

@@ -78,9 +78,9 @@ func TestNewCDKComponent(t *testing.T) {
 		assert.Equal(t, lwcomponent.UpdateAvailable, component.Status)
 	})
 
-	t.Run("Installed Deprecated No API", func(t *testing.T) {
+	t.Run("Installed No API", func(t *testing.T) {
 		var (
-			name string = "installed-deprecated-no-api"
+			name string = "installed-no-api"
 			ver  string = "1.1.1"
 		)
 
@@ -92,7 +92,7 @@ func TestNewCDKComponent(t *testing.T) {
 
 		component := lwcomponent.NewCDKComponent(nil, hostInfo)
 
-		assert.Equal(t, lwcomponent.InstalledDeprecated, component.Status)
+		assert.Equal(t, lwcomponent.Installed, component.Status)
 	})
 
 	t.Run("Installed Deprecated API", func(t *testing.T) {