Unv data file with bad data format exported from simcenter test.lab can not read

[masonacezllk]

The following data file 'test.unv',which exported from Simcenter Test.lab 2021 in binary format, can not load with pyuff in python.
I found that this unv file is badly format.
I changed the _extract58 function in dataset_58.py file to correct load my 'test.unv' data, code changed list below:

if binary:
            split_data = b''.join(block_data.splitlines(True)[13:])
            if dset['byte_ordering'] == 1:
                bo = '<'
            else:
                bo = '>'
            if (dset['ord_data_type'] == 2) or (dset['ord_data_type'] == 5):
                # single precision - 4 bytes
                values = np.asarray(struct.unpack('%c%sf' % (bo, int(len(split_data) / 4)), split_data[:int(len(split_data) / 4)*4]), 'd')
            else:
                # double precision - 8 bytes
                values = np.asarray(struct.unpack('%c%sd' % (bo, int(len(split_data) / 8)), split_data[:int(len(split_data) / 8)*8]), 'd')

After Changed this codes, I finally load my data.
Is that right?

test.zip

[jankoslavic]

Thank you @masonacezllk ! can you prepare a pull request please?

[jankoslavic]

dear @masonacezllk there are several datasets in the attached test.zip file. Can you please prepare a minimum working example? (single dataset, short example of data)

[jankoslavic]

@masonacezllk is this still valid?

[masonacezllk]

@masonacezllk is this still valid?
Original Code:
pyuff/tree/main/pyuff/datasets/dataset_58.py Line 1094:
values = np.asarray(struct.unpack('%c%sf' % (bo, int(len(split_data) / 4)), split_data), 'd')

Changed like below:
values = np.asarray(struct.unpack('%c%sf' % (bo, int(len(split_data) / 4)), split_data[:int(len(split_data) / 4)*4]), 'd')

Then I could load uff data correctly.

[jankoslavic]

Ok, I have now been able to identify the cause: the wrong use of CRLF in the dataset 58b. Your solution handles the issue correctly if the datafile is not properly written (in 58b, there should be no CRLF before " -1" which is used to separate datasets)

Can you please double check if the current code works for you?

[jankoslavic]

@masonacezllk did you get the message above :) ?

[masonacezllk]

Sorry for my poor English, The come which i changed works finechanged. Thanks for checking the code.😊

…

---Original--- From: "Janko ***@***.***> Date: Tue, May 13, 2025 21:36 PM To: ***@***.***>; Cc: "Masonacez ***@***.******@***.***>; Subject: Re: [ladisk/pyuff] Unv data file with bad data format exported fromsimcenter test.lab can not read (Issue #88) jankoslavic left a comment (ladisk/pyuff#88) @masonacezllk did you get the message above :) ? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

[jankoslavic]

I understand all is fine :) and will finish this pull request :)