Skip to content

Support for UFF18 #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
janheindejong opened this issue Aug 29, 2024 · 4 comments
Open

Support for UFF18 #90

janheindejong opened this issue Aug 29, 2024 · 4 comments

Comments

@janheindejong
Copy link

Great tool, love it!

I saw it doesn't officially support UFF18, but there seems to be code to do so. Any plans to officially support this?
@jankoslavic
Copy link
Contributor

dear @janheindejong I invite you to prepare a pull request; you can count on my support.

@janheindejong
Copy link
Author

janheindejong commented Aug 29, 2024 •
edited
Loading

Ok, I'll give it a crack. Upon closer inspection I see the code that is in there is just partial reading of UFF18, am I right?

@jankoslavic
Copy link
Contributor

Yes, please start from the code available. Try to keep similar logic as is used elsewhere. Add a simple testing as used for other datatypes.

@jankoslavic
Copy link
Contributor

Hi @janheindejong any progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jankoslavic @janheindejong