Skip to content

feature request: read_sets() without loading data #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jlmoreno93 opened this issue Nov 27, 2024 · 3 comments
Closed

feature request: read_sets() without loading data #94

jlmoreno93 opened this issue Nov 27, 2024 · 3 comments

Comments

@jlmoreno93
Copy link
Contributor

Hi pyuff developers,

First off, thank you for your fantastic work on this library and your contributions to the structural dynamics community!

Regarding the read_sets() function: Would it be possible to add an option to read only the metadata without loading the actual data (data and x)?

This would be helpful for reducing computation time when just browsing dataset channels in large UFF files (1GB+), where read_data() can take 25+ seconds to execute. It could also enable a more lazy loading approach when implementing in applications.

I experimented with this on dataset 58, and by adding this functionality to read in just metadata, the processing time was reduced to a couple of seconds.

Is this something that could be considered for a future update? I would be happy to contribute.

@jankoslavic
Copy link
Contributor

@jlmoreno93 this is a great suggestion. Can you try to prepare a pull request?

@jlmoreno93
Copy link
Contributor Author

Definitely, I will try to come up with something presentable.

@jankoslavic
Copy link
Contributor

This issue is resolved with PR: #95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants