Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEXT_PUBLIC_ variables are a lazy developer hack #17452

Open
4 of 5 tasks
DavideDelbianco opened this issue Apr 4, 2025 · 2 comments · May be fixed by #17535
Open
4 of 5 tasks

NEXT_PUBLIC_ variables are a lazy developer hack #17452

DavideDelbianco opened this issue Apr 4, 2025 · 2 comments · May be fixed by #17535
Assignees
@crazywoola

Comments

@DavideDelbianco
Copy link

DavideDelbianco commented Apr 4, 2025 •
edited
Loading

Self Checks

  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report (我已阅读并同意 Language Policy).
  • [FOR CHINESE USERS] 请务必使用英文提交 Issue，否则会被关闭。谢谢！:)
  • Please do not modify this template :) and fill in all the required fields.

1. Is this request related to a challenge you're experiencing? Tell me about your story.

Injecting configuration variables in the DOM using those NEXT_PUBLIC_ variables just to avoid restarting the Docker image during development time is increasing the amount of non-necessary variables in HTML and also led to two PR where the "contributor" did not understand what he was copying and the code submitted is not working.

2. Additional context or comments

#15964
#16805

3. Can you help us with this feature?

  • I am interested in contributing to this feature.
@crazywoola crazywoola self-assigned this Apr 5, 2025
@crazywoola
Copy link
Member

I don't remember why we add those variables at the first place, I will check it with our frontend developers later.

Thanks for the feedback again :)

@DavideDelbianco
Copy link
Author

In the linked PRs there's a passive-aggressive explanation of why the code submitted does not work.
It's not that I don't know how to write in English, I'm just tired of untested code being submitted and merged in the repo that's used for paying customers too.

Sometimes they don't harm the project (like those 2 PRs) sometimes they do.

I could have fixed it, instead of explaining why it is wrong, but i think it is better to point out the error and have the author fix their mistake (if they will ever come back to the repo to fix it) otherwise they think they did good and continue to spread garbage contributions to open source projects

@XiaoBa-Yu XiaoBa-Yu linked a pull request Apr 7, 2025 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crazywoola crazywoola

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix MAX_PARALLEL_LIMIT && MAX_ITERATIONS_NUM environment value XiaoBa-Yu/dify-xb
2 participants
@DavideDelbianco @crazywoola