Skip to content

Commit 908050e

Browse files
committed
refactor
1 parent 1de8fe1 commit 908050e

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

src/QueryViewerServiceProvider.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
class QueryViewerServiceProvider extends \Illuminate\Support\ServiceProvider
99
{
10-
const CONFIG_PATH = __DIR__ . '/../config/query-viewer.php';
10+
const CONFIG_PATH = __DIR__.'/../config/query-viewer.php';
1111

1212
public function boot()
1313
{
@@ -25,7 +25,7 @@ public function register()
2525

2626
$queryBuilderMixin = new QueryBuilderMixin();
2727

28-
// TODO: use mixin method for laravel 7 and 8.
28+
// TODO: use mixin for laravel version >= 7.
2929
foreach (get_class_methods($queryBuilderMixin) as $method) {
3030
EloquentQueryBuilder::macro($method, $queryBuilderMixin->{$method}());
3131
QueryBuilder::macro($method, $queryBuilderMixin->{$method}());

tests/QueryViewerTest.php

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public function testGetSqlMethodExistsOnEloquentBuilder()
2424
{
2525
$this->assertEquals(
2626
'select `name` from `test_table` where `id` = 5',
27-
EloquentBuilderTest::select('name')->where('id', 5)->getSql()
27+
EloquentBuilderTestModel::select('name')->where('id', 5)->getSql()
2828
);
2929
}
3030

@@ -37,6 +37,9 @@ public function testGetSqlMethodExistsOnDatabaseBuilder()
3737
}
3838
}
3939

40-
class EloquentBuilderTest extends \Illuminate\Database\Eloquent\Model {
40+
class EloquentBuilderTestModel extends \Illuminate\Database\Eloquent\Model
41+
{
4142
protected $table = 'test_table';
42-
};
43+
}
44+
45+
;

0 commit comments

Comments
 (0)