Skip to content

Commit bf6b57d

Browse files
committed
Optionally skip if no auth_token is provided
1 parent adb02ff commit bf6b57d

File tree

3 files changed

+7
-1
lines changed

3 files changed

+7
-1
lines changed

src/Http/Controllers/RetrievesAuthRequestFromSession.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ trait RetrievesAuthRequestFromSession
1919
*/
2020
protected function assertValidAuthToken(Request $request)
2121
{
22-
if ($request->session()->get('authToken') !== $request->get('auth_token')) {
22+
if ($request->has('auth_token') && $request->session()->get('authToken') !== $request->get('auth_token')) {
2323
throw InvalidAuthTokenException::different();
2424
}
2525
}

tests/ApproveAuthorizationControllerTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ public function test_complete_authorization_request()
2626

2727
$request = m::mock(Request::class);
2828
$request->shouldReceive('session')->andReturn($session = m::mock());
29+
$request->shouldReceive('has')->with('auth_token')->andReturn(true);
2930
$request->shouldReceive('get')->with('auth_token')->andReturn('foo');
3031

3132
$session->shouldReceive('get')->once()->with('authToken')->andReturn('foo');

tests/DenyAuthorizationControllerTest.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ public function test_authorization_can_be_denied()
2727
$request->shouldReceive('session')->andReturn($session = m::mock());
2828
$request->shouldReceive('user')->andReturn(new DenyAuthorizationControllerFakeUser);
2929
$request->shouldReceive('input')->with('state')->andReturn('state');
30+
$request->shouldReceive('has')->with('auth_token')->andReturn(true);
3031
$request->shouldReceive('get')->with('auth_token')->andReturn('foo');
3132

3233
$session->shouldReceive('get')->once()->with('authToken')->andReturn('foo');
@@ -58,6 +59,7 @@ public function test_authorization_can_be_denied_with_multiple_redirect_uris()
5859
$request->shouldReceive('session')->andReturn($session = m::mock());
5960
$request->shouldReceive('user')->andReturn(new DenyAuthorizationControllerFakeUser);
6061
$request->shouldReceive('input')->with('state')->andReturn('state');
62+
$request->shouldReceive('has')->with('auth_token')->andReturn(true);
6163
$request->shouldReceive('get')->with('auth_token')->andReturn('foo');
6264

6365
$session->shouldReceive('get')->once()->with('authRequest')->andReturn($authRequest = m::mock(
@@ -89,6 +91,7 @@ public function test_authorization_can_be_denied_implicit()
8991
$request->shouldReceive('session')->andReturn($session = m::mock());
9092
$request->shouldReceive('user')->andReturn(new DenyAuthorizationControllerFakeUser);
9193
$request->shouldReceive('input')->with('state')->andReturn('state');
94+
$request->shouldReceive('has')->with('auth_token')->andReturn(true);
9295
$request->shouldReceive('get')->with('auth_token')->andReturn('foo');
9396

9497
$session->shouldReceive('get')->once()->with('authToken')->andReturn('foo');
@@ -120,6 +123,7 @@ public function test_authorization_can_be_denied_with_existing_query_string()
120123
$request->shouldReceive('session')->andReturn($session = m::mock());
121124
$request->shouldReceive('user')->andReturn(new DenyAuthorizationControllerFakeUser);
122125
$request->shouldReceive('input')->with('state')->andReturn('state');
126+
$request->shouldReceive('has')->with('auth_token')->andReturn(true);
123127
$request->shouldReceive('get')->with('auth_token')->andReturn('foo');
124128

125129
$session->shouldReceive('get')->once()->with('authToken')->andReturn('foo');
@@ -154,6 +158,7 @@ public function test_auth_request_should_exist()
154158
$request->shouldReceive('session')->andReturn($session = m::mock());
155159
$request->shouldReceive('user')->never();
156160
$request->shouldReceive('input')->never();
161+
$request->shouldReceive('has')->with('auth_token')->andReturn(true);
157162
$request->shouldReceive('get')->with('auth_token')->andReturn('foo');
158163

159164
$session->shouldReceive('get')->once()->with('authToken')->andReturn('foo');

0 commit comments

Comments
 (0)