Use ESLint+Prettier to lint the whole repo, and fix Benchmark per each PR (contra#58)

Author: dotansimha

.eslintignore

@@ -0,0 +1,2 @@
+packages/core/lib/render-graphiql.ts
+packages/deno/

.eslintrc.json

@@ -0,0 +1,65 @@
+{
+  "parser": "@typescript-eslint/parser",
+  "extends": [
+    "eslint:recommended",
+    "standard",
+    "prettier",
+    "plugin:@typescript-eslint/recommended"
+  ],
+  "plugins": ["@typescript-eslint", "promise"],
+  "rules": {
+    "no-empty": "off",
+    "no-console": "error",
+    "no-prototype-builtins": "off",
+    "no-useless-constructor": "off",
+    "@typescript-eslint/no-unused-vars": ["warn", {"args":  "none"}],
+    "@typescript-eslint/no-use-before-define": "off",
+    "@typescript-eslint/no-namespace": "off",
+    "@typescript-eslint/no-empty-interface": "off",
+    "@typescript-eslint/no-empty-function": "off",
+    "@typescript-eslint/no-var-requires": "off",
+    "@typescript-eslint/no-explicit-any": "off",
+    "@typescript-eslint/no-non-null-assertion": "off",
+    "@typescript-eslint/explicit-function-return-type": "off",
+    "@typescript-eslint/ban-ts-ignore": "off",
+    "@typescript-eslint/ban-types": "off",
+    "no-use-before-define": "off"
+  },
+  "env": {
+    "es6": true,
+    "node": true
+  },
+  "overrides": [
+    {
+      "files": [
+        "./packages/deno/**/*.ts",
+        "./benchmark/**/*.js"
+      ],
+      "rules": {
+      }
+    },
+    {
+      "files": [
+        "./examples/**/*.ts"
+      ],
+      "rules": {
+        "no-console": "off"
+      }
+    },
+    {
+      "files": [
+        "**/tests/**/*.ts",
+        "**/test/**/*.ts",
+        "*.spec.ts"
+      ],
+      "env": {
+        "jest": true
+      },
+      "rules": {
+        "@typescript-eslint/no-unused-vars": "off",
+        "@typescript-eslint/explicit-module-boundary-types": "off"
+      }
+    }
+  ],
+  "ignorePatterns": ["dist", "node_modules", "dev-test", "website"]
+}

.github/workflows/benchmark.yml

@@ -39,4 +39,4 @@ jobs:
         run: |
           yarn loadtest:start-server &
           yarn wait-on tcp:5000
-          k6 -e GITHUB_PR=${{ github.event.number }} -e GITHUB_SHA=${{ github.sha }} -e GITHUB_TOKEN=${{secrets.GH_API_TOKEN}} -e GRAPHQL_HOSTNAME=0.0.0.0 run ./benchmark/k6.js 
+          k6 -e GITHUB_PR=${{ github.event.number }} -e GITHUB_SHA=${{ github.sha }} -e GITHUB_TOKEN=${{ secrets.GITHUB_TOKEN }} -e GRAPHQL_HOSTNAME=0.0.0.0 run ./benchmark/k6.js 

.github/workflows/ci.yml

@@ -17,8 +17,7 @@ jobs:
         with:
           node-version: ${{ matrix.node-version }}
       - run: yarn install --frozen-lockfile
-      - run: yarn workspace graphql-helix lint
-      - run: yarn workspace @graphql-helix/graphiql lint
+      - run: yarn lint
       - run: yarn workspace graphql-helix build
       - run: yarn workspace graphql-helix test
         env:

.gitignore

@@ -6,4 +6,5 @@ node_modules
 !.github
 !.prettierignore
 !.prettierrc
-
+!.eslintrc.json
+!.eslintignore

.prettierrc

@@ -1,5 +1,5 @@
 {
-  "printWidth": 80,
+  "printWidth": 130,
   "jsxSingleQuote": false,
   "tabWidth": 2,
   "useTabs": false,

benchmark/github.js

@@ -2,7 +2,7 @@
 import { check } from "k6";
 import { textSummary } from "https://jslib.k6.io/k6-summary/0.0.1/index.js";
 import { graphql, checkNoErrors } from "./utils.js";
-import { githubComment } from "./github.js";
+import { githubComment } from "https://raw.githubusercontent.com/dotansimha/k6-github-pr-comment/master/lib.js";
 
 export const options = {
   vus: 1,
@@ -19,8 +19,8 @@ export function handleSummary(data) {
     token: __ENV.GITHUB_TOKEN,
     commit: __ENV.GITHUB_SHA,
     pr: __ENV.GITHUB_PR,
-    org: "dotansimha",
-    repo: "envelop",
+    org: "contrawork",
+    repo: "graphql-helix",
     renderTitle({ passes }) {
       return passes ? "✅ Benchmark Results" : "❌ Benchmark Failed";
     },
@@ -34,15 +34,11 @@ export function handleSummary(data) {
       }
 
       if (checks.failures) {
-        result.push(
-          "**Failed assertions detected**: some GraphQL operations included in the loadtest are failing."
-        );
+        result.push("**Failed assertions detected**: some GraphQL operations included in the loadtest are failing.");
       }
 
       if (!passes) {
-        result.push(
-          `> If the performance regression is expected, please increase the failing threshold.`
-        );
+        result.push(`> If the performance regression is expected, please increase the failing threshold.`);
       }
 
       return result.join("\n");

benchmark/k6.js

@@ -13,6 +13,7 @@
     "examples/*"
   ],
   "scripts": {
+    "lint": "eslint --ext .ts,.tsx .",
     "publish": "node scripts/publish",
     "update-examples": "node scripts/update-examples",
     "loadtest:start-server": "node ./benchmark/server.js"
@@ -23,14 +24,30 @@
     }
   },
   "lint-staged": {
-    "*.{js,ts,tsx,json,css}": "prettier --write"
+    "*.{ts,tsx}": [
+      "eslint --fix"
+    ],
+    "**/*.{ts,tsx,graphql,yml}": [
+      "prettier --write"
+    ],
+    "**/*.json": [
+      "prettier --write"
+    ]
   },
   "devDependencies": {
     "@changesets/cli": "2.17.0",
     "@types/k6": "0.32.2",
+    "@typescript-eslint/eslint-plugin": "^4.31.2",
+    "@typescript-eslint/parser": "4.31.2",
+    "eslint": "7.32.0",
+    "eslint-config-prettier": "8.3.0",
+    "eslint-config-standard": "16.0.3",
+    "eslint-plugin-import": "2.24.2",
+    "eslint-plugin-node": "11.1.0",
+    "eslint-plugin-promise": "5.1.0",
     "husky": "7.0.2",
     "lint-staged": "11.1.2",
-    "prettier": "2.4.0",
+    "prettier": "2.4.1",
     "wait-on": "6.0.0"
   },
   "resolutions": {