FIX various PHP8 exceptions

count(NULL)
DS -> DIRECTORY_SEPARATOR

FIX Exception

FIX TaskPivotPlugin: array_filter changed behaviour with PHP8 ?

LIB gettext exception

https://github.com/smmoosavi/php-gettext-core

Author: lbayle

admin/edit_team.php

@@ -493,7 +493,7 @@ private function getOnDutyCandidates(Team $team, array $projList) {
    private function getOnDutyTasks(Team $team) {
 
       $bugidList = $team->getOnDutyTasks();
-      if (is_null($bugidList) || empty($bugidList)) { return NULL; }
+      if (is_null($bugidList) || empty($bugidList)) { return array(); }
 
       $onDutyTasks = array();
       foreach ($bugidList as $bugid) {

classes/controller.class.php

@@ -71,7 +71,7 @@ protected function updateTeamSelector() {
          $this->session_user = UserCache::getInstance()->getUser($_SESSION['userid']);
          $this->teamList = $this->session_user->getTeamList();
 
-         if (count($this->teamList) > 0) {
+         if ((NULL != $this->teamList) && (count($this->teamList) > 0)) {
             $this->smartyHelper->assign('teams', SmartyTools::getSmartyArray($this->teamList, $_SESSION['teamid']));
          }
 

i18n/gettext.php

@@ -98,7 +98,7 @@ function readintarray($count) {
    * @param object Reader the StreamReader object
    * @param boolean enable_cache Enable or disable caching of strings (default on)
    */
-  function gettext_reader($Reader, $enable_cache = true) {
+  function __construct($Reader, $enable_cache = true) {
     // If there isn't a StreamReader, turn on short circuit mode.
     if (! $Reader || isset($Reader->error) ) {
       $this->short_circuit = true;
@@ -352,7 +352,7 @@ function get_plural_forms() {
   function select_string($n) {
     $string = $this->get_plural_forms();
     $string = str_replace('nplurals',"\$total",$string);
-    $string = str_replace("n",$n,$string);
+    $string = str_replace("n",(int)$n,$string);
     $string = str_replace('plural',"\$plural",$string);
 
     $total = 0;

i18n/streams.php

@@ -49,7 +49,7 @@ class StringReader {
   var $_pos;
   var $_str;
 
-  function StringReader($str='') {
+  function __construct($str='') {
     $this->_str = $str;
     $this->_pos = 0;
   }
@@ -86,7 +86,7 @@ class FileReader {
   var $_fd;
   var $_length;
 
-  function FileReader($filename) {
+  function __construct($filename) {
     if (file_exists($filename)) {
 
       $this->_length=filesize($filename);
@@ -143,7 +143,7 @@ function close() {
 // Preloads entire file in memory first, then creates a StringReader
 // over it (it assumes knowledge of StringReader internals)
 class CachedFileReader extends StringReader {
-  function CachedFileReader($filename) {
+  function __construct($filename) {
     if (file_exists($filename)) {
 
       $length=filesize($filename);

indicator_plugins/EffortEstimReliabilityIndicator/EffortEstimReliabilityIndicator.class.php

@@ -36,7 +36,7 @@ public function getName() {
       return __CLASS__;
    }
    public static function getSmartyFilename() {
-      return Constants::$codevRootDir.DS.self::indicatorPluginsDir.DS.__CLASS__.DS.__CLASS__.".html";
+      return Constants::$codevRootDir.DIRECTORY_SEPARATOR.self::indicatorPluginsDir.DIRECTORY_SEPARATOR.__CLASS__.DIRECTORY_SEPARATOR.__CLASS__.".html";
    }
 
   // ----------------------------------------------

indicator_plugins/StatusHistoryIndicator/StatusHistoryIndicator.class.php

@@ -52,7 +52,7 @@ public function getName() {
       return __CLASS__;
    }
    public static function getSmartyFilename() {
-      return Constants::$codevRootDir.DS.self::indicatorPluginsDir.DS.__CLASS__.DS.__CLASS__.".html";
+      return Constants::$codevRootDir.DIRECTORY_SEPARATOR.self::indicatorPluginsDir.DIRECTORY_SEPARATOR.__CLASS__.DIRECTORY_SEPARATOR.__CLASS__.".html";
    }
 
 

plugins/StatusHistoryIndicator2/StatusHistoryIndicator2.class.php

@@ -130,7 +130,7 @@ public function initialize(PluginDataProviderInterface $pluginDataProv) {
       } else {
          $this->interval = 30;
       }
-      $this->isDisplayResolved = fasle;
+      $this->isDisplayResolved = false;
       //self::$logger->debug('dataProvider '.PluginDataProviderInterface::PARAM_INTERVAL.'= '.$this->interval);
    }
 

plugins/TasksPivotTable/TasksPivotTable.class.php

@@ -175,7 +175,7 @@ public function setPluginSettings($pluginSettings) {
 
             // cleanup selected filters (remove empty lines)
             $this->filterList = explode(',', $tmpSelectedFilters);
-            $this->filterList = array_filter($this->filterList, create_function('$a','return $a!="";'));
+            $this->filterList = array_filter($this->filterList, 'arrayFilter_fct');
          }
       }
    }
@@ -184,7 +184,7 @@ private function setDialogboxFilters() {
 
       // cleanup allFilters (remove empty lines)
       $tmpList = explode(',', self::$allFilters);
-      $tmpList = array_filter($tmpList, create_function('$a','return $a!="";'));
+      $tmpList = array_filter($tmpList, 'arrayFilter_fct');
 
       $allFilterList = array();
       foreach ($tmpList as $class_name) {
@@ -406,5 +406,9 @@ private function getIssues($explodeResults, $filterDisplayNames, $smartyVariable
 
 }
 
+function arrayFilter_fct($a) {
+   return $a!="";
+}
+
 // Initialize complex static variables
 TasksPivotTable::staticInit();

reports/check.php

@@ -73,7 +73,7 @@ private function getTeamConsistencyErrors($teamid) {
 
       $cerrList = $ccheck->check();
 
-      $cerrs = NULL;
+      $cerrs = array();
       if (count($cerrList) > 0) {
          $i = 0;
          foreach ($cerrList as $cerr) {
@@ -117,4 +117,3 @@ private function getTeamConsistencyErrors($teamid) {
 $controller = new CheckController('../', 'Consistency Check','ConsistencyCheck');
 $controller->execute();
 
-?>

reports/planning_report.php

@@ -220,9 +220,9 @@ private function getConsistencyErrors($teamid) {
       $cerrList  = $ccheck->checkBadBacklog();
       #$cerrList2 = $ccheck->checkUnassignedTasks();
 
-      $consistencyErrors = NULL;
-      if (count($cerrList) > 0 || count($cerrList2) > 0) {
-         $consistencyErrors = array();
+      $consistencyErrors = array();
+      if (count($cerrList) > 0) {
+      //if (count($cerrList) > 0 || count($cerrList2) > 0) {
          foreach ($cerrList as $cerr) {
             $user = UserCache::getInstance()->getUser($cerr->userId);
             $issue = IssueCache::getInstance()->getIssue($cerr->bugId);

smarty_tools.php

@@ -70,7 +70,7 @@ public static function getSmartyArray(array $list, $selected) {
          }
          return $smartyList;
       } else {
-         return NULL;
+         return array();
       }
    }
 

tpl/form/selectItemsDialogbox.html

@@ -163,13 +163,13 @@
       <fieldset>
          <div style="float:left;">
             <label for="sortableSource" id="availItemListLabel"></label>
-            <ul id="sortableSource" class="sortable droptrue" style="height:{math equation="(x + y) * 37" x=$availItemList|count y=$selectedItemList|count}px">
+            <ul id="sortableSource" class="sortable droptrue" style="height:10px">
             </ul>
          </div>
 
          <div style="float:left;">
             <label for="sortableTarget" id="selectedItemListLabel"></label>
-            <ul id="sortableTarget" class="sortable droptrue" style="height:{math equation="(x +y) * 37" x=$availItemList|count y=$selectedItemList|count}px">
+            <ul id="sortableTarget" class="sortable droptrue" style="height:10px">
             </ul>
          </div>
          <!-- itemSelection_srcRef is a reference to identify the origin (projectid, cmdid, ...) -->